Skip to content
Browse files
build: add workaround for V8 builds
V8's build toolchain is not compatible with Python 3 and the CI job
that tests V8 needs to be run with Python 2. Add a fallback to
`find_executable` from `distutils.spawn` to allow the configure
script to run in the V8 test job.

PR-URL: #38632
Reviewed-By: Michaël Zasso <>
Reviewed-By: Darshan Sen <>
Reviewed-By: James M Snell <>
Reviewed-By: Rich Trott <>
  • Loading branch information
richardlau authored and targos committed Jun 11, 2021
1 parent 754aa38 commit 5df0f35bf6e9cd556e6223a351535e90a8fecfb3
Showing with 6 additions and 1 deletion.
  1. +6 −1
@@ -14,7 +14,12 @@
import bz2
import io

from shutil import which
# Fallback to find_executable from distutils.spawn is a stopgap for
# supporting V8 builds, which do not yet support Python 3.
from shutil import which
except ImportError:
from distutils.spawn import find_executable as which
from distutils.version import StrictVersion

# If not run from node/, cd to node/.

0 comments on commit 5df0f35

Please sign in to comment.