@@ -287,6 +287,34 @@ from stalling indefinitely or objections from being overridden by the TSC.
287
287
Remember that all private discussions about a nomination will be visible to
288
288
the nominee once they are onboarded.
289
289
290
+ #### How to review a collaborator nomination
291
+
292
+ A collaborator nomination can be reviewed in the same way one would review a PR
293
+ adding a feature:
294
+
295
+ * If you see the nomination as something positive to the project, say so!
296
+ * If you are neutral, or feel you don't know enough to have an informed opinion,
297
+ it's certainly OK to not interact with the nomination.
298
+ * If you think the nomination was made too soon, or can be detrimental to the
299
+ project, share your concerns, ideally before the public nomination is opened,
300
+ and avoid sharing those concerns outside of the Collaborator discussion area.
301
+ Ideally, list what step(s) the nominee could take that would make you
302
+ approve their nomination.
303
+ Given that there is no "Request for changes" feature in discussions and issues,
304
+ try to be explicit when your comment is expressing a blocking concern.
305
+ Similarly, once the blocking concern has been addressed, explicitly say so.
306
+
307
+ Our goal is to keep gate-keeping at a minimal, but it cannot be zero since being
308
+ a collaborator requires trust (collaborators can start CI jobs, use their veto,
309
+ push commits, etc.), so what's the minimal amount is subjective, and there will
310
+ be cases where collaborators disagree on whether a nomination should move
311
+ forward.
312
+
313
+ When concerns have been raised on the private discussion, refrain from opening
314
+ the public issue. If no one has explicitly blocked the nomination and you'd like
315
+ it to move forward, comment something like "If I don't hear any objections
316
+ before (some time), I will open the public issue".
317
+
290
318
### Onboarding
291
319
292
320
After the nomination passes, a TSC member onboards the new collaborator. See
0 commit comments