Skip to content

Commit 621b66a

Browse files
aduh95marco-ippolito
authored andcommitted
doc: add review guidelines for collaborator nominations
PR-URL: #57449 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
1 parent b1009b5 commit 621b66a

File tree

1 file changed

+28
-0
lines changed

1 file changed

+28
-0
lines changed

GOVERNANCE.md

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -287,6 +287,34 @@ from stalling indefinitely or objections from being overridden by the TSC.
287287
Remember that all private discussions about a nomination will be visible to
288288
the nominee once they are onboarded.
289289

290+
#### How to review a collaborator nomination
291+
292+
A collaborator nomination can be reviewed in the same way one would review a PR
293+
adding a feature:
294+
295+
* If you see the nomination as something positive to the project, say so!
296+
* If you are neutral, or feel you don't know enough to have an informed opinion,
297+
it's certainly OK to not interact with the nomination.
298+
* If you think the nomination was made too soon, or can be detrimental to the
299+
project, share your concerns, ideally before the public nomination is opened,
300+
and avoid sharing those concerns outside of the Collaborator discussion area.
301+
Ideally, list what step(s) the nominee could take that would make you
302+
approve their nomination.
303+
Given that there is no "Request for changes" feature in discussions and issues,
304+
try to be explicit when your comment is expressing a blocking concern.
305+
Similarly, once the blocking concern has been addressed, explicitly say so.
306+
307+
Our goal is to keep gate-keeping at a minimal, but it cannot be zero since being
308+
a collaborator requires trust (collaborators can start CI jobs, use their veto,
309+
push commits, etc.), so what's the minimal amount is subjective, and there will
310+
be cases where collaborators disagree on whether a nomination should move
311+
forward.
312+
313+
When concerns have been raised on the private discussion, refrain from opening
314+
the public issue. If no one has explicitly blocked the nomination and you'd like
315+
it to move forward, comment something like "If I don't hear any objections
316+
before (some time), I will open the public issue".
317+
290318
### Onboarding
291319

292320
After the nomination passes, a TSC member onboards the new collaborator. See

0 commit comments

Comments
 (0)