Skip to content
Permalink
Browse files

benchmark: add clear connections to secure-pair

adds clear connections to the secure-pair performance test to prove
that in some cases (when the sender send the data in small chunks)
clear connections perform worse than TLS connections

Also add a byte chunk size test to benchmark/net/net-pipe.js

Refs: #27970

PR-URL: #27971
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
  • Loading branch information
DiegoTUI authored and BridgeAR committed May 30, 2019
1 parent 54c471a commit 625744d292a1aa556f6fe49af46bcf47c8315065
Showing with 8 additions and 4 deletions.
  1. +1 −1 benchmark/net/net-pipe.js
  2. +7 −3 benchmark/tls/secure-pair.js
@@ -6,7 +6,7 @@ const net = require('net');
const PORT = common.PORT;

const bench = common.createBenchmark(main, {
len: [64, 102400, 1024 * 1024 * 16],
len: [2, 64, 102400, 1024 * 1024 * 16],
type: ['utf', 'asc', 'buf'],
dur: [5],
});
@@ -2,8 +2,8 @@
const common = require('../common.js');
const bench = common.createBenchmark(main, {
dur: [5],
securing: ['SecurePair', 'TLSSocket'],
size: [2, 1024, 1024 * 1024]
securing: ['SecurePair', 'TLSSocket', 'clear'],
size: [2, 100, 1024, 1024 * 1024]
});

const fixtures = require('../../test/common/fixtures');
@@ -37,7 +37,8 @@ function main({ dur, size, securing }) {
isServer: false,
rejectUnauthorized: false,
};
const conn = tls.connect(clientOptions, () => {
const network = securing === 'clear' ? net : tls;
const conn = network.connect(clientOptions, () => {
setTimeout(() => {
const mbits = (received * 8) / (1024 * 1024);
bench.end(mbits);
@@ -69,6 +70,9 @@ function main({ dur, size, securing }) {
case 'TLSSocket':
secureTLSSocket(conn, client);
break;
case 'clear':
conn.pipe(client);
break;
default:
throw new Error('Invalid securing method');
}

0 comments on commit 625744d

Please sign in to comment.
You can’t perform that action at this time.