Skip to content

Commit

Permalink
test: refactor promises to async/await
Browse files Browse the repository at this point in the history
PR-URL: #44980
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
  • Loading branch information
sonimadhuri authored and danielleadams committed Jan 3, 2023
1 parent 88351b9 commit 657756f
Showing 1 changed file with 99 additions and 120 deletions.
219 changes: 99 additions & 120 deletions test/sequential/test-debugger-break.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,123 +9,102 @@ const startCLI = require('../common/debugger');
const assert = require('assert');
const path = require('path');

// Stepping through breakpoints.
{
const scriptFullPath = fixtures.path('debugger', 'break.js');
const script = path.relative(process.cwd(), scriptFullPath);
const cli = startCLI([script]);

function onFatal(error) {
cli.quit();
throw error;
}

cli.waitForInitialBreak()
.then(() => cli.waitForPrompt())
.then(() => {
assert.deepStrictEqual(
cli.breakInfo,
{ filename: script, line: 1 },
);
assert.match(
cli.output,
/> 1 (?:\(function \([^)]+\) \{ )?const x = 10;/,
'shows the source and marks the current line');
})
.then(() => cli.stepCommand('n'))
.then(() => {
assert.ok(
cli.output.includes(`break in ${script}:2`),
'pauses in next line of the script');
assert.match(
cli.output,
/> 2 let name = 'World';/,
'marks the 2nd line');
})
.then(() => cli.stepCommand('next'))
.then(() => {
assert.ok(
cli.output.includes(`break in ${script}:3`),
'pauses in next line of the script');
assert.match(
cli.output,
/> 3 name = 'Robin';/,
'marks the 3nd line');
})
.then(() => cli.stepCommand('cont'))
.then(() => {
assert.ok(
cli.output.includes(`break in ${script}:10`),
'pauses on the next breakpoint');
assert.match(
cli.output,
/>10 debugger;/,
'marks the debugger line');
})

// Prepare additional breakpoints
.then(() => cli.command('sb("break.js", 6)'))
.then(() => assert.doesNotMatch(cli.output, /Could not resolve breakpoint/))
.then(() => cli.command('sb("otherFunction()")'))
.then(() => cli.command('sb(16)'))
.then(() => assert.doesNotMatch(cli.output, /Could not resolve breakpoint/))
.then(() => cli.command('breakpoints'))
.then(() => {
assert.ok(cli.output.includes(`#0 ${script}:6`));
assert.ok(cli.output.includes(`#1 ${script}:16`));
})

.then(() => cli.command('list()'))
.then(() => {
assert.match(
cli.output,
/>10 debugger;/,
'prints and marks current line'
);
assert.deepStrictEqual(
cli.parseSourceLines(),
[5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15],
);
})
.then(() => cli.command('list(2)'))
.then(() => {
assert.match(
cli.output,
/>10 debugger;/,
'prints and marks current line'
);
assert.deepStrictEqual(
cli.parseSourceLines(),
[8, 9, 10, 11, 12],
);
})

.then(() => cli.stepCommand('s'))
.then(() => cli.stepCommand(''))
.then(() => {
assert.match(
cli.output,
/break in node:timers/,
'entered timers.js');
})
.then(() => cli.stepCommand('cont'))
.then(() => {
assert.ok(
cli.output.includes(`break in ${script}:16`),
'found breakpoint we set above w/ line number only');
})
.then(() => cli.stepCommand('cont'))
.then(() => {
assert.ok(
cli.output.includes(`break in ${script}:6`),
'found breakpoint we set above w/ line number & script');
})
.then(() => cli.stepCommand(''))
.then(() => {
assert.ok(
cli.output.includes(`debugCommand in ${script}:14`),
'found function breakpoint we set above');
})
.then(() => cli.quit())
.then(null, onFatal);
}
const scriptFullPath = fixtures.path('debugger', 'break.js');
const script = path.relative(process.cwd(), scriptFullPath);
const cli = startCLI([script]);

(async () => {
await cli.waitForInitialBreak();
await cli.waitForPrompt();
assert.deepStrictEqual(
cli.breakInfo,
{ filename: script, line: 1 },
);
assert.match(
cli.output,
/> 1 (?:\(function \([^)]+\) \{ )?const x = 10;/,
'shows the source and marks the current line');

await cli.stepCommand('n');
assert.ok(
cli.output.includes(`break in ${script}:2`),
'pauses in next line of the script');
assert.match(
cli.output,
/> 2 let name = 'World';/,
'marks the 2nd line');

await cli.stepCommand('next');
assert.ok(
cli.output.includes(`break in ${script}:3`),
'pauses in next line of the script');
assert.match(
cli.output,
/> 3 name = 'Robin';/,
'marks the 3nd line');

await cli.stepCommand('cont');
assert.ok(
cli.output.includes(`break in ${script}:10`),
'pauses on the next breakpoint');
assert.match(
cli.output,
/>10 debugger;/,
'marks the debugger line');

await cli.command('sb("break.js", 6)');
assert.doesNotMatch(cli.output, /Could not resolve breakpoint/);

await cli.command('sb("otherFunction()")');
await cli.command('sb(16)');
assert.doesNotMatch(cli.output, /Could not resolve breakpoint/);

await cli.command('breakpoints');
assert.ok(cli.output.includes(`#0 ${script}:6`));
assert.ok(cli.output.includes(`#1 ${script}:16`));

await cli.command('list()');
assert.match(
cli.output,
/>10 debugger;/,
'prints and marks current line'
);
assert.deepStrictEqual(
cli.parseSourceLines(),
[5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15],
);

await cli.command('list(2)');
assert.match(
cli.output,
/>10 debugger;/,
'prints and marks current line'
);
assert.deepStrictEqual(
cli.parseSourceLines(),
[8, 9, 10, 11, 12],
);

await cli.stepCommand('s');
await cli.stepCommand('');
assert.match(
cli.output,
/break in node:timers/,
'entered timers.js');

await cli.stepCommand('cont');
assert.ok(
cli.output.includes(`break in ${script}:16`),
'found breakpoint we set above w/ line number only');

await cli.stepCommand('cont');
assert.ok(
cli.output.includes(`break in ${script}:6`),
'found breakpoint we set above w/ line number & script');

await cli.stepCommand('');
assert.ok(
cli.output.includes(`debugCommand in ${script}:14`),
'found function breakpoint we set above');
})().finally(() => cli.quit())
.then(common.mustCall());

0 comments on commit 657756f

Please sign in to comment.