Permalink
Browse files

deps: backport 3700a01c82 from upstream v8

Original commit message:

    Make v8::Eternal::Get and IsEmpty const.

    They do not modify the state of the handle.

    Review-Url: https://codereview.chromium.org/2753973002
    Cr-Commit-Position: refs/heads/master@{#43907}

Ref: v8/v8@3700a01

PR-URL: #12875
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information...
jeremyroman authored and jasnell committed Mar 17, 2017
1 parent 9edd6d8 commit 69161b5f94b5473de1fc68833ca9647e975b46cd
Showing with 4 additions and 5 deletions.
  1. +4 −5 deps/v8/include/v8.h
View
@@ -366,8 +366,8 @@ template <class T> class Eternal {
Set(isolate, handle);
}
// Can only be safely called if already set.
V8_INLINE Local<T> Get(Isolate* isolate);
V8_INLINE bool IsEmpty() { return index_ == kInitialValue; }
V8_INLINE Local<T> Get(Isolate* isolate) const;
V8_INLINE bool IsEmpty() const { return index_ == kInitialValue; }
template<class S> V8_INLINE void Set(Isolate* isolate, Local<S> handle);
private:
@@ -8604,9 +8604,8 @@ void Eternal<T>::Set(Isolate* isolate, Local<S> handle) {
V8::Eternalize(isolate, reinterpret_cast<Value*>(*handle), &this->index_);
}
template<class T>
Local<T> Eternal<T>::Get(Isolate* isolate) {
template <class T>
Local<T> Eternal<T>::Get(Isolate* isolate) const {
return Local<T>(reinterpret_cast<T*>(*V8::GetEternal(isolate, index_)));
}

0 comments on commit 69161b5

Please sign in to comment.