Skip to content

Commit 74a0948

Browse files
Uzlopaktargos
authored andcommitted
inspector: undici as shared-library should pass tests
PR-URL: #59837 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
1 parent 92128a8 commit 74a0948

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

test/parallel/test-inspector-network-websocket.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,16 +11,18 @@ const WebSocketServer = require('../common/websocket-server');
1111
const inspector = require('node:inspector/promises');
1212
const dc = require('diagnostics_channel');
1313

14+
const nameRE = 'undici' in process.versions ? /^node:internal\/deps\/undici\/undici$/u : /undici/u;
15+
1416
const session = new inspector.Session();
1517
session.connect();
1618

1719
dc.channel('undici:websocket:socket_error').subscribe((message) => {
1820
console.error('WebSocket error:', message);
1921
});
2022

21-
function findFrameInInitiator(scriptName, initiator) {
23+
function findFrameInInitiator(regex, initiator) {
2224
const frame = initiator.stack.callFrames.find((it) => {
23-
return it.url === scriptName;
25+
return regex.test(it.url);
2426
});
2527
return frame;
2628
}
@@ -39,7 +41,7 @@ async function test() {
3941
assert.ok(message.params.requestId);
4042
assert.strictEqual(typeof message.params.initiator, 'object');
4143
assert.strictEqual(message.params.initiator.type, 'script');
42-
assert.ok(findFrameInInitiator('node:internal/deps/undici/undici', message.params.initiator));
44+
assert.ok(findFrameInInitiator(nameRE, message.params.initiator));
4345
requestId = message.params.requestId;
4446
}));
4547

0 commit comments

Comments
 (0)