-
Notifications
You must be signed in to change notification settings - Fork 28.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
crypto: validate
this in all webcrypto methods and getters
PR-URL: #42815 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
- Loading branch information
Showing
2 changed files
with
206 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,159 @@ | ||
| // Flags: --experimental-global-webcrypto | ||
| 'use strict'; | ||
|
|
||
| const common = require('../common'); | ||
|
|
||
| if (!common.hasCrypto) | ||
| common.skip('missing crypto'); | ||
|
|
||
| const assert = require('assert'); | ||
|
|
||
| // Test CryptoKey constructor | ||
| { | ||
| assert.throws(() => new CryptoKey(), { | ||
| name: 'TypeError', message: 'Illegal constructor', code: 'ERR_ILLEGAL_CONSTRUCTOR' | ||
| }); | ||
| } | ||
|
|
||
| // Test SubtleCrypto constructor | ||
| { | ||
| assert.throws(() => new SubtleCrypto(), { | ||
| name: 'TypeError', message: 'Illegal constructor', code: 'ERR_ILLEGAL_CONSTRUCTOR' | ||
| }); | ||
| } | ||
|
|
||
| // Test Crypto constructor | ||
| { | ||
| assert.throws(() => new Crypto(), { | ||
| name: 'TypeError', message: 'Illegal constructor', code: 'ERR_ILLEGAL_CONSTRUCTOR' | ||
| }); | ||
| } | ||
|
|
||
| const notCrypto = Reflect.construct(function() {}, [], Crypto); | ||
| const notSubtle = Reflect.construct(function() {}, [], SubtleCrypto); | ||
|
|
||
| // Test Crypto.prototype.subtle | ||
| { | ||
| assert.throws(() => notCrypto.subtle, { | ||
| name: 'TypeError', code: 'ERR_INVALID_THIS', | ||
| }); | ||
| } | ||
|
|
||
| // Test Crypto.prototype.randomUUID | ||
| { | ||
| assert.throws(() => notCrypto.randomUUID(), { | ||
| name: 'TypeError', code: 'ERR_INVALID_THIS', | ||
| }); | ||
| } | ||
|
|
||
| // Test Crypto.prototype.getRandomValues | ||
| { | ||
| assert.throws(() => notCrypto.getRandomValues(new Uint8Array(12)), { | ||
| name: 'TypeError', code: 'ERR_INVALID_THIS', | ||
| }); | ||
| } | ||
|
|
||
| // Test SubtleCrypto.prototype.encrypt | ||
| { | ||
| assert.rejects(() => notSubtle.encrypt(), { | ||
| name: 'TypeError', code: 'ERR_INVALID_THIS', | ||
| }).then(common.mustCall()); | ||
| } | ||
|
|
||
| // Test SubtleCrypto.prototype.decrypt | ||
| { | ||
| assert.rejects(() => notSubtle.decrypt(), { | ||
| name: 'TypeError', code: 'ERR_INVALID_THIS', | ||
| }).then(common.mustCall()); | ||
| } | ||
|
|
||
| // Test SubtleCrypto.prototype.sign | ||
| { | ||
| assert.rejects(() => notSubtle.sign(), { | ||
| name: 'TypeError', code: 'ERR_INVALID_THIS', | ||
| }).then(common.mustCall()); | ||
| } | ||
|
|
||
| // Test SubtleCrypto.prototype.verify | ||
| { | ||
| assert.rejects(() => notSubtle.verify(), { | ||
| name: 'TypeError', code: 'ERR_INVALID_THIS', | ||
| }).then(common.mustCall()); | ||
| } | ||
|
|
||
| // Test SubtleCrypto.prototype.digest | ||
| { | ||
| assert.rejects(() => notSubtle.digest(), { | ||
| name: 'TypeError', code: 'ERR_INVALID_THIS', | ||
| }).then(common.mustCall()); | ||
| } | ||
|
|
||
| // Test SubtleCrypto.prototype.generateKey | ||
| { | ||
| assert.rejects(() => notSubtle.generateKey(), { | ||
| name: 'TypeError', code: 'ERR_INVALID_THIS', | ||
| }).then(common.mustCall()); | ||
| } | ||
|
|
||
| // Test SubtleCrypto.prototype.deriveKey | ||
| { | ||
| assert.rejects(() => notSubtle.deriveKey(), { | ||
| name: 'TypeError', code: 'ERR_INVALID_THIS', | ||
| }).then(common.mustCall()); | ||
| } | ||
|
|
||
| // Test SubtleCrypto.prototype.deriveBits | ||
| { | ||
| assert.rejects(() => notSubtle.deriveBits(), { | ||
| name: 'TypeError', code: 'ERR_INVALID_THIS', | ||
| }).then(common.mustCall()); | ||
| } | ||
|
|
||
| // Test SubtleCrypto.prototype.importKey | ||
| { | ||
| assert.rejects(() => notSubtle.importKey(), { | ||
| name: 'TypeError', code: 'ERR_INVALID_THIS', | ||
| }).then(common.mustCall()); | ||
| } | ||
|
|
||
| // Test SubtleCrypto.prototype.exportKey | ||
| { | ||
| assert.rejects(() => notSubtle.exportKey(), { | ||
| name: 'TypeError', code: 'ERR_INVALID_THIS', | ||
| }).then(common.mustCall()); | ||
| } | ||
|
|
||
| // Test SubtleCrypto.prototype.wrapKey | ||
| { | ||
| assert.rejects(() => notSubtle.wrapKey(), { | ||
| name: 'TypeError', code: 'ERR_INVALID_THIS', | ||
| }).then(common.mustCall()); | ||
| } | ||
|
|
||
| // Test SubtleCrypto.prototype.unwrapKey | ||
| { | ||
| assert.rejects(() => notSubtle.unwrapKey(), { | ||
| name: 'TypeError', code: 'ERR_INVALID_THIS', | ||
| }).then(common.mustCall()); | ||
| } | ||
|
|
||
| { | ||
| globalThis.crypto.subtle.importKey( | ||
| 'raw', | ||
| globalThis.crypto.getRandomValues(new Uint8Array(4)), | ||
| 'PBKDF2', | ||
| false, | ||
| ['deriveKey'], | ||
| ).then((key) => { | ||
| globalThis.crypto.subtle.importKey = common.mustNotCall(); | ||
| return globalThis.crypto.subtle.deriveKey({ | ||
| name: 'PBKDF2', | ||
| hash: 'SHA-512', | ||
| salt: globalThis.crypto.getRandomValues(new Uint8Array()), | ||
| iterations: 5, | ||
| }, key, { | ||
| name: 'AES-GCM', | ||
| length: 256 | ||
| }, true, ['encrypt', 'decrypt']); | ||
| }).then(common.mustCall()); | ||
| } |