-
Notifications
You must be signed in to change notification settings - Fork 28.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
test: run code cache test by default and test generator
- Add the code cache tests to the default test suite, and test the bookkeeping when the binary is not built with the code cache. - Test the code cache generator to make sure we do not accidentally break it - until we enable code cache in the CI. Refs: #21563 PR-URL: #23855 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
- Loading branch information
1 parent
5ff1e67
commit 7a2134c
Showing
3 changed files
with
88 additions
and
17 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
'use strict'; | ||
|
||
// This test verifies that the binary is compiled with code cache and the | ||
// cache is used when built in modules are compiled. | ||
|
||
const common = require('../common'); | ||
|
||
const tmpdir = require('../common/tmpdir'); | ||
const { spawnSync } = require('child_process'); | ||
const assert = require('assert'); | ||
const path = require('path'); | ||
const fs = require('fs'); | ||
const readline = require('readline'); | ||
|
||
const generator = path.join( | ||
__dirname, '..', '..', 'tools', 'generate_code_cache.js' | ||
); | ||
tmpdir.refresh(); | ||
const dest = path.join(tmpdir.path, 'cache.cc'); | ||
|
||
// Run tools/generate_code_cache.js | ||
const child = spawnSync( | ||
process.execPath, | ||
['--expose-internals', generator, dest] | ||
); | ||
assert.ifError(child.error); | ||
if (child.status !== 0) { | ||
console.log(child.stderr.toString()); | ||
assert.strictEqual(child.status, 0); | ||
} | ||
|
||
// Verifies that: | ||
// - node::DefineCodeCache() | ||
// - node::DefineCodeCacheHash() | ||
// are defined in the generated code. | ||
// See src/node_code_cache_stub.cc for explanations. | ||
|
||
const rl = readline.createInterface({ | ||
input: fs.createReadStream(dest), | ||
crlfDelay: Infinity | ||
}); | ||
|
||
let hasCacheDef = false; | ||
let hasHashDef = false; | ||
|
||
rl.on('line', common.mustCallAtLeast((line) => { | ||
if (line.includes('DefineCodeCache(')) { | ||
hasCacheDef = true; | ||
} | ||
if (line.includes('DefineCodeCacheHash(')) { | ||
hasHashDef = true; | ||
} | ||
}, 2)); | ||
|
||
rl.on('close', common.mustCall(() => { | ||
assert.ok(hasCacheDef); | ||
assert.ok(hasHashDef); | ||
})); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters