Skip to content

Commit 7aa64b9

Browse files
hashseedjasnell
authored andcommitted
tools: implement ninja build with --build-v8-with-gn
PR-URL: #19201 Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
1 parent 91a5ee1 commit 7aa64b9

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

common.gypi

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,13 @@
4949
'conditions': [
5050
['GENERATOR=="ninja"', {
5151
'obj_dir': '<(PRODUCT_DIR)/obj',
52-
'v8_base': '<(PRODUCT_DIR)/obj/deps/v8/gypfiles/libv8_base.a',
52+
'conditions': [
53+
[ 'build_v8_with_gn=="true"', {
54+
'v8_base': '<(PRODUCT_DIR)/obj/deps/v8/gypfiles/v8_monolith.gen/gn/obj/libv8_monolith.a',
55+
}, {
56+
'v8_base': '<(PRODUCT_DIR)/obj/deps/v8/gypfiles/libv8_base.a',
57+
}],
58+
]
5359
}, {
5460
'obj_dir%': '<(PRODUCT_DIR)/obj.target',
5561
'v8_base': '<(PRODUCT_DIR)/obj.target/deps/v8/gypfiles/libv8_base.a',

0 commit comments

Comments
 (0)