Skip to content

Commit 8181c60

Browse files
committed
test: add regression tests
This makes sure util.isDate and util.isRegExp will not abort in case more than one argument is passed to the utility function. PR-URL: #19188 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent 9757906 commit 8181c60

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

test/parallel/test-util.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ assert.strictEqual(false, util.isArray(Object.create(Array.prototype)));
4242

4343
// isRegExp
4444
assert.strictEqual(true, util.isRegExp(/regexp/));
45-
assert.strictEqual(true, util.isRegExp(RegExp()));
45+
assert.strictEqual(true, util.isRegExp(RegExp(), 'foo'));
4646
assert.strictEqual(true, util.isRegExp(new RegExp()));
4747
assert.strictEqual(true, util.isRegExp(context('RegExp')()));
4848
assert.strictEqual(false, util.isRegExp({}));
@@ -52,7 +52,7 @@ assert.strictEqual(false, util.isRegExp(Object.create(RegExp.prototype)));
5252

5353
// isDate
5454
assert.strictEqual(true, util.isDate(new Date()));
55-
assert.strictEqual(true, util.isDate(new Date(0)));
55+
assert.strictEqual(true, util.isDate(new Date(0), 'foo'));
5656
assert.strictEqual(true, util.isDate(new (context('Date'))()));
5757
assert.strictEqual(false, util.isDate(Date()));
5858
assert.strictEqual(false, util.isDate({}));

0 commit comments

Comments
 (0)