Skip to content

Commit 8198e78

Browse files
addaleaxBethGriggs
authored andcommitted
deps: V8: stub backport 9e52d5c5d717
Refs: v8/v8@9e52d5c PR-URL: #32885 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
1 parent a27852a commit 8198e78

File tree

4 files changed

+9
-4
lines changed

4 files changed

+9
-4
lines changed

common.gypi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535

3636
# Reset this number to 0 on major V8 upgrades.
3737
# Increment by one for each non-official patch applied to deps/v8.
38-
'v8_embedder_string': '-node.26',
38+
'v8_embedder_string': '-node.27',
3939

4040
##### V8 defaults for Node.js #####
4141

deps/v8/include/v8-inspector.h

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,10 @@ class V8_EXPORT V8InspectorSession {
145145
virtual void breakProgram(StringView breakReason,
146146
StringView breakDetails) = 0;
147147
virtual void setSkipAllPauses(bool) = 0;
148-
virtual void resume() = 0;
148+
149+
// NOTE: setTerminateOnResume is not implemented on the base version of
150+
// Node.js v14.0.0 / V8 8.1.
151+
virtual void resume(bool setTerminateOnResume = false) = 0;
149152
virtual void stepOver() = 0;
150153
virtual std::vector<std::unique_ptr<protocol::Debugger::API::SearchMatch>>
151154
searchInTextByLines(StringView text, StringView query, bool caseSensitive,

deps/v8/src/inspector/v8-inspector-session-impl.cc

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -448,7 +448,9 @@ void V8InspectorSessionImpl::setSkipAllPauses(bool skip) {
448448
m_debuggerAgent->setSkipAllPauses(skip);
449449
}
450450

451-
void V8InspectorSessionImpl::resume() { m_debuggerAgent->resume(); }
451+
void V8InspectorSessionImpl::resume(bool terminateOnResume) {
452+
m_debuggerAgent->resume();
453+
}
452454

453455
void V8InspectorSessionImpl::stepOver() { m_debuggerAgent->stepOver(); }
454456

deps/v8/src/inspector/v8-inspector-session-impl.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ class V8InspectorSessionImpl : public V8InspectorSession,
7777
void cancelPauseOnNextStatement() override;
7878
void breakProgram(StringView breakReason, StringView breakDetails) override;
7979
void setSkipAllPauses(bool) override;
80-
void resume() override;
80+
void resume(bool terminateOnResume = false) override;
8181
void stepOver() override;
8282
std::vector<std::unique_ptr<protocol::Debugger::API::SearchMatch>>
8383
searchInTextByLines(StringView text, StringView query, bool caseSensitive,

0 commit comments

Comments
 (0)