Skip to content

Commit

Permalink
src: use default initializers over settings fields on the constructor
Browse files Browse the repository at this point in the history
PR-URL: #23532
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  • Loading branch information
andrewjdmccann authored and jasnell committed Oct 17, 2018
1 parent ffab8ba commit 866d81c
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
4 changes: 1 addition & 3 deletions src/spawn_sync.cc
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,7 @@ using v8::String;
using v8::Value;


SyncProcessOutputBuffer::SyncProcessOutputBuffer()
: used_(0),
next_(nullptr) {
SyncProcessOutputBuffer::SyncProcessOutputBuffer() {
}


Expand Down
4 changes: 2 additions & 2 deletions src/spawn_sync.h
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,9 @@ class SyncProcessOutputBuffer {
private:
// Use unsigned int because that's what `uv_buf_init` takes.
mutable char data_[kBufferSize];
unsigned int used_;
unsigned int used_ = 0;

SyncProcessOutputBuffer* next_;
SyncProcessOutputBuffer* next_ = nullptr;
};


Expand Down

0 comments on commit 866d81c

Please sign in to comment.