test: simplify fs promises test

dnalborczyk · targos · commit 887dd604f199 · 2019-06-03T13:14:24.000+02:00
Simplify test, fix comment. PR-URL: #27242 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
diff --git a/test/parallel/test-fs-promises.js b/test/parallel/test-fs-promises.js
@@ -40,8 +40,11 @@ function nextdir() {
   return `test${++dirc}`;
 }
 
-// fs.promises should not enumerable.
-assert.strictEqual(Object.keys(fs).includes('promises'), true);
+// fs.promises should be enumerable.
+assert.strictEqual(
+  Object.prototype.propertyIsEnumerable.call(fs, 'promises'),
+  true
+);
 
 {
   access(__filename, 'r')

Original file line number	Diff line number	Diff line change
`@@ -40,8 +40,11 @@ function nextdir() {`
`40`	`40`	return `test${++dirc}`;
`41`	`41`	`}`
`42`	`42`
`43`		`-// fs.promises should not enumerable.`
`44`		`-assert.strictEqual(Object.keys(fs).includes('promises'), true);`
	`43`	`+// fs.promises should be enumerable.`
	`44`	`+assert.strictEqual(`
	`45`	`+ Object.prototype.propertyIsEnumerable.call(fs, 'promises'),`
	`46`	`+ true`
	`47`	`+);`
`45`	`48`
`46`	`49`	`{`
`47`	`50`	`access(__filename, 'r')`