Skip to content

Commit 8cf9400

Browse files
ofrobotsAli Sheikh
authored andcommitted
build: do not ignore errors during build-addons
Errors during build-addons were being silently ignored. PR-URL: #5494 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com>
1 parent 536cfec commit 8cf9400

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ test/addons/.buildstamp: $(ADDONS_BINDING_GYPS) | test/addons/.docbuildstamp
144144
for dirname in test/addons/*/; do \
145145
$(NODE) deps/npm/node_modules/node-gyp/bin/node-gyp rebuild \
146146
--directory="$$PWD/$$dirname" \
147-
--nodedir="$$PWD"; \
147+
--nodedir="$$PWD" || exit 1 ; \
148148
done
149149
touch $@
150150

0 commit comments

Comments
 (0)