Skip to content

Commit 8d84154

Browse files
richardlautargos
authored andcommitted
build: don't pass --mode argument to V8 test-runner
V8's test-runner dropped the `--mode` argument some time back, and now produces the following error if run with it: run-tests.py: error: no such option: --mode PR-URL: #39055 Refs: #35705 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent 1b74d3f commit 8d84154

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -665,12 +665,12 @@ test-v8: v8 ## Runs the V8 test suite on deps/v8.
665665
test-v8-intl: v8
666666
export PATH="$(NO_BIN_OVERRIDE_PATH)" && \
667667
deps/v8/tools/run-tests.py --gn --arch=$(V8_ARCH) \
668-
--mode=$(BUILDTYPE_LOWER) intl \
668+
intl \
669669
$(TAP_V8_INTL)
670670

671671
test-v8-benchmarks: v8
672672
export PATH="$(NO_BIN_OVERRIDE_PATH)" && \
673-
deps/v8/tools/run-tests.py --gn --arch=$(V8_ARCH) --mode=$(BUILDTYPE_LOWER) \
673+
deps/v8/tools/run-tests.py --gn --arch=$(V8_ARCH) \
674674
benchmarks \
675675
$(TAP_V8_BENCHMARKS)
676676

0 commit comments

Comments
 (0)