Skip to content
Permalink
Browse files

test: increase coverage of buffer

PR-URL: #11122
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
  • Loading branch information...
DavidCai1993 authored and jasnell committed Feb 3, 2017
1 parent 950ef82 commit 901cb8cb5e2eb887e1889f8f7946c71a642e14c0
Showing with 13 additions and 0 deletions.
  1. +2 −0 test/parallel/test-buffer-compare-offset.js
  2. +11 −0 test/parallel/test-buffer-write-noassert.js
@@ -11,6 +11,7 @@ assert.strictEqual(-1, a.compare(b));
// Equivalent to a.compare(b).
assert.strictEqual(-1, a.compare(b, 0));
assert.strictEqual(-1, a.compare(b, '0'));
assert.strictEqual(-1, a.compare(b, undefined));

// Equivalent to a.compare(b).
assert.strictEqual(-1, a.compare(b, 0, undefined, 0));
@@ -63,5 +64,6 @@ assert.throws(() => a.compare(b, 0, 1, 0, 100), oor);
assert.throws(() => a.compare(b, -1), oor);
assert.throws(() => a.compare(b, 0, '0xff'), oor);
assert.throws(() => a.compare(b, 0, Infinity), oor);
assert.throws(() => a.compare(b, 0, 1, -1), oor);
assert.throws(() => a.compare(b, -Infinity, Infinity), oor);
assert.throws(() => a.compare(), /Argument must be a Buffer/);
@@ -20,6 +20,17 @@ function write(funx, args, result, res) {
);
}

{
const error = /Int/.test(funx) ?
/^TypeError: "buffer" argument must be a Buffer or Uint8Array$/ :
/^TypeError: argument should be a Buffer$/;

assert.throws(
() => Buffer.alloc(9)[funx].apply(new Uint32Array(1), args),
error
);
}

{
const buf2 = Buffer.alloc(9);
assert.strictEqual(buf2[funx](...args, true), result);

0 comments on commit 901cb8c

Please sign in to comment.
You can’t perform that action at this time.