test: move inspector tests to parallel/sequential

* remove inspector directory artifacts

PR-URL: #16197
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Makefile

@@ -409,9 +409,6 @@ test-pummel: all
 test-internet: all
 	$(PYTHON) tools/test.py internet
 
-test-inspector: all
-	$(PYTHON) tools/test.py inspector
-
 test-node-inspect: $(NODE_EXE)
 	USE_EMBEDDED_NODE_INSPECT=1 $(NODE) tools/test-npm-package \
 		--install deps/node-inspect test

test/README.md

@@ -19,7 +19,6 @@ On how to run tests in this directory, see
 |es-module          |Yes            |Test ESM module loading.|
 |fixtures           |               |Test fixtures used in various tests throughout the test suite.|
 |gc                 |No             |Tests for garbage collection related functionality.|
-|inspector          |Yes            |Tests for the V8 inspector integration.|
 |internet           |No             |Tests that make real outbound connections (mainly networking related modules). Tests for networking related modules may also be present in        other directories, but those tests do not make outbound connections.|
 |known_issues       |Yes            |Tests reproducing known issues within the system. All tests inside of this directory are expected to fail consistently. If a test doesn't fail on certain platforms, those should be skipped via `known_issues.status`.|
 |message            |Yes            |Tests for messages that are output for various conditions (```console.log```, error messages etc.)|

test/parallel/parallel.status

@@ -7,6 +7,9 @@ prefix parallel
 [true] # This section applies to all platforms
 
 [$system==win32]
+test-inspector-bindings               : PASS, FLAKY
+test-inspector-debug-end              : PASS, FLAKY
+test-inspector-stop-profile-after-done: PASS, FLAKY
 
 [$system==linux]
 
@@ -19,3 +22,5 @@ test-npm-install:      PASS,FLAKY
 
 [$system==freebsd]
 
+[$system==aix]
+test-inspector-stop-profile-after-done: PASS, FLAKY

test/inspector/test-async-hook-setup-at-inspect.js → test/parallel/test-inspect-async-hook-setup-at-inspect.js

@@ -3,7 +3,7 @@ const common = require('../common');
 common.skipIfInspectorDisabled();
 common.skipIf32Bits();
 common.crashOnUnhandledRejection();
-const { NodeInstance } = require('../inspector/inspector-helper.js');
+const { NodeInstance } = require('../common/inspector-helper.js');
 const assert = require('assert');
 
 // Even with --inspect, the default async call stack depth is 0. We need a

test/inspector/test-async-hook-setup-at-inspect-brk.js → test/parallel/test-inspector-async-hook-setup-at-inspect-brk.js

@@ -3,7 +3,7 @@ const common = require('../common');
 common.skipIfInspectorDisabled();
 common.skipIf32Bits();
 common.crashOnUnhandledRejection();
-const { NodeInstance } = require('./inspector-helper.js');
+const { NodeInstance } = require('../common/inspector-helper.js');
 const assert = require('assert');
 
 const script = `

test/inspector/test-async-hook-setup-at-signal.js → test/parallel/test-inspector-async-hook-setup-at-signal.js

@@ -3,7 +3,7 @@ const common = require('../common');
 common.skipIfInspectorDisabled();
 common.skipIf32Bits();
 common.crashOnUnhandledRejection();
-const { NodeInstance } = require('../inspector/inspector-helper.js');
+const { NodeInstance } = require('../common/inspector-helper.js');
 const assert = require('assert');
 
 const script = `

test/inspector/test-async-stack-traces-promise-then.js → test/parallel/test-inspector-async-stack-traces-promise-then.js

@@ -3,7 +3,7 @@ const common = require('../common');
 common.skipIfInspectorDisabled();
 common.skipIf32Bits();
 common.crashOnUnhandledRejection();
-const { NodeInstance } = require('./inspector-helper');
+const { NodeInstance } = require('../common/inspector-helper');
 const assert = require('assert');
 
 const script = `runTest();

test/inspector/test-async-stack-traces-set-interval.js → test/parallel/test-inspector-async-stack-traces-set-interval.js

@@ -3,7 +3,7 @@ const common = require('../common');
 common.skipIfInspectorDisabled();
 common.skipIf32Bits();
 common.crashOnUnhandledRejection();
-const { NodeInstance } = require('./inspector-helper');
+const { NodeInstance } = require('../common/inspector-helper');
 const assert = require('assert');
 
 const script = 'setInterval(() => { debugger; }, 50);';

test/inspector/test-inspector-break-e.js → test/parallel/test-inspector-break-e.js

@@ -4,7 +4,7 @@ const common = require('../common');
 common.skipIfInspectorDisabled();
 
 const assert = require('assert');
-const { NodeInstance } = require('./inspector-helper.js');
+const { NodeInstance } = require('../common/inspector-helper.js');
 
 async function runTests() {
   const instance = new NodeInstance(undefined, 'console.log(10)');

test/inspector/test-break-when-eval.js → test/parallel/test-inspector-break-when-eval.js

@@ -2,10 +2,10 @@
 const common = require('../common');
 common.skipIfInspectorDisabled();
 const assert = require('assert');
-const { NodeInstance } = require('./inspector-helper.js');
-const path = require('path');
+const { NodeInstance } = require('../common/inspector-helper.js');
+const fixtures = require('../common/fixtures');
 
-const script = path.join(path.dirname(module.filename), 'global-function.js');
+const script = fixtures.path('inspector-global-function.js');
 
 async function setupDebugger(session) {
   console.log('[test]', 'Setting up a debugger');

test/inspector/test-debug-brk-flag.js → test/parallel/test-inspector-debug-brk-flag.js

@@ -5,7 +5,7 @@ common.skipIfInspectorDisabled();
 
 const assert = require('assert');
 const { mainScriptPath,
-        NodeInstance } = require('./inspector-helper.js');
+        NodeInstance } = require('../common/inspector-helper.js');
 
 async function testBreakpointOnStart(session) {
   const commands = [

test/inspector/test-debug-end.js → test/parallel/test-inspector-debug-end.js

@@ -2,7 +2,7 @@
 const common = require('../common');
 common.skipIfInspectorDisabled();
 const { strictEqual } = require('assert');
-const { NodeInstance } = require('./inspector-helper.js');
+const { NodeInstance } = require('../common/inspector-helper.js');
 
 async function testNoServerNoCrash() {
   console.log('Test there\'s no crash stopping server that was not started');

test/inspector/test-exception.js → test/parallel/test-inspector-exception.js

@@ -5,7 +5,7 @@ const fixtures = require('../common/fixtures');
 common.skipIfInspectorDisabled();
 
 const assert = require('assert');
-const { NodeInstance } = require('./inspector-helper.js');
+const { NodeInstance } = require('../common/inspector-helper.js');
 
 const script = fixtures.path('throws_error.js');
 

test/inspector/test-ip-detection.js → test/parallel/test-inspector-ip-detection.js

@@ -4,7 +4,7 @@ const common = require('../common');
 common.skipIfInspectorDisabled();
 
 const assert = require('assert');
-const { NodeInstance } = require('./inspector-helper.js');
+const { NodeInstance } = require('../common/inspector-helper.js');
 const os = require('os');
 
 const ip = pickIPv4Address();

test/inspector/test-not-blocked-on-idle.js → test/parallel/test-inspector-not-blocked-on-idle.js

@@ -1,7 +1,7 @@
 'use strict';
 const common = require('../common');
 common.skipIfInspectorDisabled();
-const { NodeInstance } = require('./inspector-helper.js');
+const { NodeInstance } = require('../common/inspector-helper.js');
 
 async function runTests() {
   const script = 'setInterval(() => {debugger;}, 60000);';

test/inspector/test-scriptparsed-context.js → test/parallel/test-inspector-scriptparsed-context.js

@@ -2,7 +2,7 @@
 const common = require('../common');
 common.skipIfInspectorDisabled();
 common.crashOnUnhandledRejection();
-const { NodeInstance } = require('./inspector-helper.js');
+const { NodeInstance } = require('../common/inspector-helper.js');
 const assert = require('assert');
 
 const script = `

test/inspector/test-stop-profile-after-done.js → test/parallel/test-inspector-stop-profile-after-done.js

@@ -2,7 +2,7 @@
 const common = require('../common');
 common.skipIfInspectorDisabled();
 const assert = require('assert');
-const { NodeInstance } = require('./inspector-helper.js');
+const { NodeInstance } = require('../common/inspector-helper.js');
 
 async function runTests() {
   const child = new NodeInstance(['--inspect=0'],

test/inspector/test-inspector.js → test/parallel/test-inspector.js

@@ -6,7 +6,7 @@ common.skipIfInspectorDisabled();
 const assert = require('assert');
 const { mainScriptPath,
         readMainScriptSource,
-        NodeInstance } = require('./inspector-helper.js');
+        NodeInstance } = require('../common/inspector-helper.js');
 
 function checkListResponse(response) {
   assert.strictEqual(1, response.length);

vcbuild.bat

@@ -81,7 +81,6 @@ if /i "%1"=="test-addons-napi"   set test_args=%test_args% addons-napi&set build
 if /i "%1"=="test-simple"   set test_args=%test_args% sequential parallel -J&goto arg-ok
 if /i "%1"=="test-message"  set test_args=%test_args% message&goto arg-ok
 if /i "%1"=="test-gc"       set test_args=%test_args% gc&set build_testgc_addon=1&goto arg-ok
-if /i "%1"=="test-inspector" set test_args=%test_args% inspector&goto arg-ok
 if /i "%1"=="test-tick-processor" set test_args=%test_args% tick-processor&goto arg-ok
 if /i "%1"=="test-internet" set test_args=%test_args% internet&goto arg-ok
 if /i "%1"=="test-pummel"   set test_args=%test_args% pummel&goto arg-ok
@@ -536,7 +535,7 @@ echo Failed to create vc project files.
 goto exit
 
 :help
-echo vcbuild.bat [debug/release] [msi] [test/test-ci/test-all/test-uv/test-inspector/test-internet/test-pummel/test-simple/test-message/test-async-hooks/test-v8/test-v8-intl/test-v8-benchmarks/test-v8-all] [clean] [noprojgen] [small-icu/full-icu/without-intl] [nobuild] [sign] [x86/x64] [vs2015/vs2017] [download-all] [enable-vtune] [lint/lint-ci] [no-NODE-OPTIONS] [link-module path-to-module]
+echo vcbuild.bat [debug/release] [msi] [test/test-ci/test-all/test-uv/test-internet/test-pummel/test-simple/test-message/test-async-hooks/test-v8/test-v8-intl/test-v8-benchmarks/test-v8-all] [clean] [noprojgen] [small-icu/full-icu/without-intl] [nobuild] [sign] [x86/x64] [vs2015/vs2017] [download-all] [enable-vtune] [lint/lint-ci] [no-NODE-OPTIONS] [link-module path-to-module]
 echo Examples:
 echo   vcbuild.bat                          : builds release build
 echo   vcbuild.bat debug                    : builds debug build