Skip to content

Commit 9b104be

Browse files
tniessenjasnell
authored andcommitted
quic: do not dereference shared_ptr after move
The stored pointer is assumed to be nullptr after std::move. PR-URL: #47294 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
1 parent c81e114 commit 9b104be

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/quic/data.cc

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,16 +38,16 @@ Store::Store(std::shared_ptr<v8::BackingStore> store,
3838
size_t length,
3939
size_t offset)
4040
: store_(std::move(store)), length_(length), offset_(offset) {
41-
CHECK_LE(offset_, store->ByteLength());
42-
CHECK_LE(length_, store->ByteLength() - offset_);
41+
CHECK_LE(offset_, store_->ByteLength());
42+
CHECK_LE(length_, store_->ByteLength() - offset_);
4343
}
4444

4545
Store::Store(std::unique_ptr<v8::BackingStore> store,
4646
size_t length,
4747
size_t offset)
4848
: store_(std::move(store)), length_(length), offset_(offset) {
49-
CHECK_LE(offset_, store->ByteLength());
50-
CHECK_LE(length_, store->ByteLength() - offset_);
49+
CHECK_LE(offset_, store_->ByteLength());
50+
CHECK_LE(length_, store_->ByteLength() - offset_);
5151
}
5252

5353
Store::Store(v8::Local<v8::ArrayBuffer> buffer, Option option)

0 commit comments

Comments
 (0)