Skip to content

Commit 9b6e797

Browse files
targosmmarchini
authored andcommitted
Revert "assert: fix line number calculation after V8 upgrade"
This reverts commit 5981fb7. PR-URL: #32116 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1 parent f90eba1 commit 9b6e797

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

common.gypi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535

3636
# Reset this number to 0 on major V8 upgrades.
3737
# Increment by one for each non-official patch applied to deps/v8.
38-
'v8_embedder_string': '-node.6',
38+
'v8_embedder_string': '-node.7',
3939

4040
##### V8 defaults for Node.js #####
4141

lib/assert.js

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -278,7 +278,7 @@ function getErrMessage(message, fn) {
278278
const call = err.stack[0];
279279

280280
const filename = call.getFileName();
281-
let line = call.getLineNumber() - 1;
281+
const line = call.getLineNumber() - 1;
282282
let column = call.getColumnNumber() - 1;
283283
let identifier;
284284
let code;
@@ -298,9 +298,6 @@ function getErrMessage(message, fn) {
298298
return message;
299299
}
300300
code = String(fn);
301-
// For functions created with the Function constructor, V8 does not count
302-
// the lines containing the function header.
303-
line += 2;
304301
identifier = `${code}${line}${column}`;
305302
}
306303

0 commit comments

Comments
 (0)