Skip to content

Commit a2c335b

Browse files
addaleaxjasnell
authored andcommitted
test: fix sequential/test-async-wrap-getasyncid
Previously, this test would contain a DNS query that timed out after 60 seconds, thus occupying one of the parallel test slots for that period. Fix that by creating a new channel for that request, and cancelling it immediately. PR-URL: #15319 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1 parent 94e2b5c commit a2c335b

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

test/parallel/test-async-wrap-getasyncid.js

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,12 @@ function testInitialized(req, ctor_name) {
5656

5757
testInitialized(dns.lookup('www.google.com', () => {}), 'GetAddrInfoReqWrap');
5858
testInitialized(dns.lookupService('::1', 22, () => {}), 'GetNameInfoReqWrap');
59-
testInitialized(dns.resolve6('::1', () => {}), 'QueryReqWrap');
60-
testInitialized(new cares.ChannelWrap(), 'ChannelWrap');
59+
60+
const resolver = new dns.Resolver();
61+
resolver.setServers(['127.0.0.1']);
62+
testInitialized(resolver._handle, 'ChannelWrap');
63+
testInitialized(resolver.resolve6('::1', () => {}), 'QueryReqWrap');
64+
resolver.cancel();
6165
}
6266

6367

0 commit comments

Comments
 (0)