Permalink
Browse files

test: refactor test-file-*

* var to const
* add check that expected error is ENOENT
* indexOf() to includes()

PR-URL: #8999
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
  • Loading branch information...
jennabelle authored and jasnell committed Oct 10, 2016
1 parent aedb72e commit aac93a5c64664c15a1adc793d145ede0ab50630a
Showing with 13 additions and 12 deletions.
  1. +6 −5 test/parallel/test-file-read-noexist.js
  2. +7 −7 test/parallel/test-file-write-stream2.js
@@ -1,10 +1,11 @@
'use strict';
var common = require('../common');
var assert = require('assert');
var path = require('path');
var fs = require('fs');
const common = require('../common');
const assert = require('assert');
const path = require('path');
const fs = require('fs');
var filename = path.join(common.fixturesDir, 'does_not_exist.txt');
const filename = path.join(common.fixturesDir, 'does_not_exist.txt');
fs.readFile(filename, 'latin1', common.mustCall(function(err, content) {
assert.ok(err);
assert.strictEqual(err.code, 'ENOENT');
}));
@@ -1,12 +1,12 @@
'use strict';
var common = require('../common');
var assert = require('assert');
const common = require('../common');
const assert = require('assert');
var path = require('path');
var fs = require('fs');
const path = require('path');
const fs = require('fs');
var filepath = path.join(common.tmpDir, 'write.txt');
const filepath = path.join(common.tmpDir, 'write.txt');
var file;
const EXPECTED = '012345678910';
@@ -76,12 +76,12 @@ file.on('close', function() {
file.on('error', function(err) {
cb_occurred += 'error ';
assert.ok(err.message.indexOf('write after end') >= 0);
assert.ok(err.message.includes('write after end'));
});
for (var i = 0; i < 11; i++) {
var ret = file.write(i + '');
const ret = file.write(i + '');
console.error('%d %j', i, ret);
// return false when i hits 10

0 comments on commit aac93a5

Please sign in to comment.