Skip to content

Commit

Permalink
test: mark test-fs-readfile-tostring-fail as flaky
Browse files Browse the repository at this point in the history
test-fs-readfile-tostring-fail is failing frequently on OSX machines.
There's a PR to fix this issue in libuv, but while the fix don't land on
Node.js this test should be marked as flaky.

Ref: #16601
Ref: libuv/libuv#1742

PR-URL: #21013
Refs: #16601
Refs: libuv/libuv#1742
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
  • Loading branch information
Matheus Marchini authored and addaleax committed May 31, 2018
1 parent ff5f20f commit adbbf0d
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions test/sequential/sequential.status
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ test-inspector-async-hook-setup-at-signal: PASS, FLAKY
[$system==linux]

[$system==macos]
# This test will be flaky until https://github.com/libuv/libuv/pull/1742 lands
# on Node.js.
test-fs-readfile-tostring-fail: PASS, FLAKY

[$system==solaris] # Also applies to SmartOS

Expand Down

0 comments on commit adbbf0d

Please sign in to comment.