Skip to content

Commit b3f0417

Browse files
jasnelltargos
authored andcommitted
src: return undefined when validation err == 0
Extracted from the QUIC PR. Not specific to QUIC even if the behavior is currently only used there. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #33107 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
1 parent 1436977 commit b3f0417

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

src/node_crypto_common.cc

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ using v8::NewStringType;
3434
using v8::Null;
3535
using v8::Object;
3636
using v8::String;
37+
using v8::Undefined;
3738
using v8::Value;
3839

3940
namespace crypto {
@@ -330,11 +331,15 @@ const char* X509ErrorCode(long err) { // NOLINT(runtime/int)
330331
}
331332

332333
MaybeLocal<Value> GetValidationErrorReason(Environment* env, int err) {
334+
if (err == 0)
335+
return Undefined(env->isolate());
333336
const char* reason = X509_verify_cert_error_string(err);
334337
return OneByteString(env->isolate(), reason);
335338
}
336339

337340
MaybeLocal<Value> GetValidationErrorCode(Environment* env, int err) {
341+
if (err == 0)
342+
return Undefined(env->isolate());
338343
return OneByteString(env->isolate(), X509ErrorCode(err));
339344
}
340345

0 commit comments

Comments
 (0)