Skip to content

Commit c38988c

Browse files
tniessentargos
authored andcommitted
crypto: fix EVPKeyCtxPointer::publicCheck()
Commit 206ebeb added an additional call to EVP_PKEY_public_check and an unconditional return from publicCheck(). This prevents the control flow from reaching the original call to either EVP_PKEY_public_check or EVP_PKEY_public_check_quick. This change restores the previous behavior, which calls EVP_PKEY_public_check_quick instead, if possible. Refs: #56812 PR-URL: #59471 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent 61c3bcd commit c38988c

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

deps/ncrypto/ncrypto.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3643,7 +3643,6 @@ EVPKeyPointer EVPKeyCtxPointer::paramgen() const {
36433643
bool EVPKeyCtxPointer::publicCheck() const {
36443644
if (!ctx_) return false;
36453645
#ifndef OPENSSL_IS_BORINGSSL
3646-
return EVP_PKEY_public_check(ctx_.get()) == 1;
36473646
#if OPENSSL_VERSION_MAJOR >= 3
36483647
return EVP_PKEY_public_check_quick(ctx_.get()) == 1;
36493648
#else

0 commit comments

Comments
 (0)