Permalink
Browse files

benchmark: remove forced optimization from url

This removes all instances of %OptimizeFunctionOnNextCall from url
benchmarks

PR-URL: #9615
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
  • Loading branch information...
bzoz committed Mar 1, 2017
1 parent ea61ce5 commit c5958d20fdf5702247e790d7ebc87c7005dc11f0
Showing with 0 additions and 11 deletions.
  1. +0 −4 benchmark/url/url-format.js
  2. +0 −7 benchmark/url/url-resolve.js
@@ -1,7 +1,6 @@
'use strict';
const common = require('../common.js');
const url = require('url');
const v8 = require('v8');
const inputs = {
slashes: {slashes: true, host: 'localhost'},
@@ -24,9 +23,6 @@ function main(conf) {
for (const name in inputs)
url.format(inputs[name]);
v8.setFlagsFromString('--allow_natives_syntax');
eval('%OptimizeFunctionOnNextCall(url.format)');
bench.start();
for (var i = 0; i < n; i += 1)
url.format(input);
@@ -1,7 +1,6 @@
'use strict';
const common = require('../common.js');
const url = require('url');
const v8 = require('v8');
const hrefs = require('../fixtures/url-inputs.js').urls;
hrefs.noscheme = 'some.ran/dom/url.thing?oh=yes#whoo';
@@ -24,12 +23,6 @@ function main(conf) {
const href = hrefs[conf.href];
const path = paths[conf.path];
// Force-optimize url.resolve() so that the benchmark doesn't get
// disrupted by the optimizer kicking in halfway through.
url.resolve(href, path);
v8.setFlagsFromString('--allow_natives_syntax');
eval('%OptimizeFunctionOnNextCall(url.resolve)');
bench.start();
for (var i = 0; i < n; i += 1)
url.resolve(href, path);

0 comments on commit c5958d2

Please sign in to comment.