Skip to content
Browse files

build: find Python syntax errors in dependencies

As discussed in
#30129 (comment), when
we vendor in code, we own the Syntax Errors in that code.  This PR adds
The `.flake8` config file at the root of this repo puts blinders on the
linting of our dependencies so this test disables that file before

fixup: allow_failures until dependencies pass

PR-URL: #30143
Reviewed-By: Rich Trott <>
Reviewed-By: Colin Ihrig <>
Reviewed-By: Richard Lau <>
Reviewed-By: Michaël Zasso <>
Reviewed-By: Jiawen Geng <>
Reviewed-By: Sam Roberts <>
  • Loading branch information
cclauss authored and targos committed Oct 27, 2019
1 parent df0fbf2 commit c5d312f821d58cc9b9df64c0f6537faa3154456c
Showing with 12 additions and 0 deletions.
  1. +12 −0 .travis.yml
@@ -91,3 +91,15 @@ jobs:
- if [ "${TRAVIS_PULL_REQUEST}" != "false" ]; then
bash -x tools/ ${TRAVIS_PULL_REQUEST};

- name: "Find syntax errors in our Python dependencies"
language: python
python: 3.8
- mv .flake8 disabled.flake8 # take the blinders off of flake8
- python3.8 -m pip install --upgrade pip
- python3.8 -m pip install flake8
- flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics
allow_failures: # TODO (cclauss): remove this when dependencies are clean
- name: "Find syntax errors in our Python dependencies"

0 comments on commit c5d312f

Please sign in to comment.
You can’t perform that action at this time.