Please sign in to comment.
stream: pipeline should use req.abort() to destroy response
destroy(err) on http response will propagate the error to the request causing 'error' to be unexpectedly emitted. Furthermore, response.destroy() unlike request.abort() does not _dump buffered data. Fixes a breaking change introduced in 6480882. Prefer res.req.abort() over res.destroy() until this situation is clarified. Fixes: #31029 Refs: 6480882 PR-URL: #31054 Reviewed-By: Luigi Pinca <email@example.com> Reviewed-By: Matteo Collina <firstname.lastname@example.org> Reviewed-By: Stephen Belanger <email@example.com> Reviewed-By: Rich Trott <firstname.lastname@example.org> Reviewed-By: Ruben Bridgewater <email@example.com>
- Loading branch information
Showing with 37 additions and 13 deletions.