Skip to content

Commit

Permalink
tools: increase timeout of running WPT
Browse files Browse the repository at this point in the history
We run all WPT from one subset in the same process using workers.
As the number of the tests grow, it can take longer to run some of the
subsets, but it's still overall faster than running them in different
processes. This patch increases the timeout
for WPT to prevent the test from failing because it takes longer
to run (even though it would still complete at some point).

PR-URL: #44574
Refs: nodejs/reliability#371
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
joyeecheung authored and RafaelGSS committed Sep 26, 2022
1 parent 2813323 commit caad474
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion tools/test.py
Original file line number Diff line number Diff line change
Expand Up @@ -957,8 +957,14 @@ def GetVm(self, arch, mode):

def GetTimeout(self, mode, section=''):
timeout = self.timeout * TIMEOUT_SCALEFACTOR[ARCH_GUESS or 'ia32'][mode]
if section == 'pummel' or section == 'benchmark' or section == 'wpt':
if section == 'pummel' or section == 'benchmark':
timeout = timeout * 6
# We run all WPT from one subset in the same process using workers.
# As the number of the tests grow, it can take longer to run some of the
# subsets, but it's still overall faster than running them in different
# processes.
elif section == 'wpt':
timeout = timeout * 12
return timeout

def RunTestCases(cases_to_run, progress, tasks, flaky_tests_mode, measure_flakiness):
Expand Down

0 comments on commit caad474

Please sign in to comment.