Please sign in to comment.
http2: remove side effects from validateSettings
The function did not only validate the input so far but it also made a copy of the input object and returned that copy to the callee function. That copy was not necessary for all call sites and it was not obvious that the function did not only validate the input but that it also returned a copy of it. This makes sure the function does nothing more than validation and copying is happening in the callee function when required. PR-URL: #26809 Reviewed-By: Matteo Collina <firstname.lastname@example.org> Reviewed-By: James M Snell <email@example.com>
- Loading branch information...