Skip to content
Permalink
Browse files

v8: backport 43791ce02c8 from upstream v8

Original commit message:
    [PATCH] [inspector] finally removed *ExecuteScript from inspector

    We don't need hints from embedder any more.

    BUG=none
    R=dgozman@chromium.org

    Review-Url: https://codereview.chromium.org/2773143002
    Cr-Commit-Position: refs/heads/master@{#44158}

PR-URL: #13217
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information...
ak239 authored and jasnell committed Mar 27, 2017
1 parent 1061e43 commit cfdcd6cf33b1fcf81db7f034fba7fdfd94d248b4
@@ -224,8 +224,6 @@ class V8_EXPORT V8Inspector {
virtual void resetContextGroup(int contextGroupId) = 0;

// Various instrumentation.
virtual void willExecuteScript(v8::Local<v8::Context>, int scriptId) = 0;
virtual void didExecuteScript(v8::Local<v8::Context>) = 0;
virtual void idleStarted() = 0;
virtual void idleFinished() = 0;

@@ -285,21 +285,6 @@ void V8InspectorImpl::resetContextGroup(int contextGroupId) {
m_debugger->wasmTranslation()->Clear();
}

void V8InspectorImpl::willExecuteScript(v8::Local<v8::Context> context,
int scriptId) {
if (V8DebuggerAgentImpl* agent =
enabledDebuggerAgentForGroup(contextGroupId(context))) {
agent->willExecuteScript(scriptId);
}
}

void V8InspectorImpl::didExecuteScript(v8::Local<v8::Context> context) {
if (V8DebuggerAgentImpl* agent =
enabledDebuggerAgentForGroup(contextGroupId(context))) {
agent->didExecuteScript();
}
}

void V8InspectorImpl::idleStarted() {
for (auto it = m_sessions.begin(); it != m_sessions.end(); ++it) {
if (it->second->profilerAgent()->idleStarted()) return;
@@ -85,8 +85,6 @@ class V8InspectorImpl : public V8Inspector {
void contextCreated(const V8ContextInfo&) override;
void contextDestroyed(v8::Local<v8::Context>) override;
void resetContextGroup(int contextGroupId) override;
void willExecuteScript(v8::Local<v8::Context>, int scriptId) override;
void didExecuteScript(v8::Local<v8::Context>) override;
void idleStarted() override;
void idleFinished() override;
unsigned exceptionThrown(v8::Local<v8::Context>, const StringView& message,

0 comments on commit cfdcd6c

Please sign in to comment.
You can’t perform that action at this time.