Skip to content

Commit d10949b

Browse files
aduh95marco-ippolito
authored andcommitted
meta: edit collaborator nomination process
- recommend more strongly a private discussion prior to a public one. - add requirement for the nominee to publicly accept the nomination. - move recommendation for heads up comment from "How to review nominations" section to "Nominating new Collaborator" section. PR-URL: #57483 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Jordan Harband <ljharb@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Ruy Adorno <ruy@vlt.sh>
1 parent 704562f commit d10949b

File tree

1 file changed

+51
-13
lines changed

1 file changed

+51
-13
lines changed

GOVERNANCE.md

Lines changed: 51 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -146,8 +146,31 @@ Contributions can be:
146146

147147
### Nominating a new Collaborator
148148

149-
To nominate a new Collaborator, open an issue in the [nodejs/node][] repository.
150-
Provide a summary of the nominee's contributions. For example:
149+
To nominate a new Collaborator:
150+
151+
1. **Optional but strongly recommended**: open a
152+
[discussion in the nodejs/collaborators][] repository. Provide a summary of
153+
the nominee's contributions (see below for an example).
154+
2. **Optional but strongly recommended**: After sufficient wait time (e.g. 72
155+
hours), if the nomination proposal has received some support and no explicit
156+
block, add a comment in the private discussion stating you're planning on
157+
opening a public issue, e.g. "I see a number of approvals and no block, I'll
158+
be opening a public nomination issue if I don't hear any objections in the
159+
next 72 hours".
160+
3. **Optional but strongly recommended**: Privately contact the nominee to make
161+
sure they're comfortable with the nomination.
162+
4. Open an issue in the [nodejs/node][] repository. Provide a summary of
163+
the nominee's contributions (see below for an example). Mention
164+
@nodejs/collaborators in the issue to notify other collaborators about
165+
the nomination.
166+
167+
The _Optional but strongly recommended_ steps are optional in the sense that
168+
skipping them would not invalidate the nomination, but it could put the nominee
169+
in a very awkward situation if a nomination they didn't ask for pops out of
170+
nowhere only to be rejected. Do not skip those steps unless you're absolutely
171+
certain the nominee is fine with the public scrutiny.
172+
173+
Example of list of contributions:
151174

152175
* Commits in the [nodejs/node][] repository.
153176
* Use the link `https://github.com/nodejs/node/commits?author=GITHUB_ID`
@@ -166,23 +189,38 @@ Provide a summary of the nominee's contributions. For example:
166189
organization
167190
* Other participation in the wider Node.js community
168191

169-
Mention @nodejs/collaborators in the issue to notify other collaborators about
170-
the nomination.
171-
172-
The nomination passes if no collaborators oppose it after one week. In the case
192+
The nomination passes if no collaborators oppose it after one week, and if the
193+
nominee publicly accepts it. In the case
173194
of an objection, the TSC is responsible for working with the individuals
174195
involved and finding a resolution.
175196

176-
There are steps a nominator can take in advance to make a nomination as
177-
frictionless as possible. To request feedback from other collaborators in
178-
private, use the [collaborators discussion page][]
179-
(which only collaborators may view). A nominator may also work with the
180-
nominee to improve their contribution profile.
181-
182197
Collaborators might overlook someone with valuable contributions. In that case,
183198
the contributor may open an issue or contact a collaborator to request a
184199
nomination.
185200

201+
#### How to review a collaborator nomination
202+
203+
A collaborator nomination can be reviewed in the same way one would review a PR
204+
adding a feature:
205+
206+
* If you see the nomination as something positive to the project, say so!
207+
* If you are neutral, or feel you don't know enough to have an informed opinion,
208+
it's certainly OK to not interact with the nomination.
209+
* If you think the nomination was made too soon, or can be detrimental to the
210+
project, share your concerns, ideally before the public nomination is opened,
211+
and avoid sharing those concerns outside of the Collaborator discussion area.
212+
Ideally, list what step(s) the nominee could take that would make you
213+
approve their nomination.
214+
Given that there is no "Request for changes" feature in discussions and issues,
215+
try to be explicit when your comment is expressing a blocking concern.
216+
Similarly, once the blocking concern has been addressed, explicitly say so.
217+
218+
Our goal is to keep gate-keeping at a minimal, but it cannot be zero since being
219+
a collaborator requires trust (collaborators can start CI jobs, use their veto,
220+
push commits, etc.), so what's the minimal amount is subjective, and there will
221+
be cases where collaborators disagree on whether a nomination should move
222+
forward.
223+
186224
### Onboarding
187225

188226
After the nomination passes, a TSC member onboards the new collaborator. See
@@ -196,6 +234,6 @@ The TSC follows a [Consensus Seeking][] decision-making model per the
196234

197235
[Consensus Seeking]: https://en.wikipedia.org/wiki/Consensus-seeking_decision-making
198236
[TSC Charter]: https://github.com/nodejs/TSC/blob/HEAD/TSC-Charter.md
199-
[collaborators discussion page]: https://github.com/nodejs/collaborators/discussions/categories/collaborator-nominations
237+
[discussion in the nodejs/collaborators]: https://github.com/nodejs/collaborators/discussions/categories/collaborator-nominations
200238
[nodejs/help]: https://github.com/nodejs/help
201239
[nodejs/node]: https://github.com/nodejs/node

0 commit comments

Comments
 (0)