Skip to content
Permalink
Browse files

inspector: add debugging for WebSocket messages

PR-URL: #21473
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information...
TimothyGu authored and targos committed Jun 22, 2018
1 parent 7d2fe5d commit d1b750d360a5a52b27ad63418d15b1e394fa3921
Showing with 9 additions and 3 deletions.
  1. +3 −3 src/env.h
  2. +6 −0 src/inspector_io.cc
@@ -415,10 +415,10 @@ struct ContextInfo {
};

// Listing the AsyncWrap provider types first enables us to cast directly
// from a provider type to a debug category. Currently no other debug
// categories are available.
// from a provider type to a debug category.
#define DEBUG_CATEGORY_NAMES(V) \
NODE_ASYNC_PROVIDER_TYPES(V)
NODE_ASYNC_PROVIDER_TYPES(V) \
V(INSPECTOR_SERVER)

enum class DebugCategory {
#define V(name) name,
@@ -314,6 +314,8 @@ void InspectorIo::SwapBehindLock(MessageQueue<ActionType>* vector1,

void InspectorIo::PostIncomingMessage(InspectorAction action, int session_id,
const std::string& message) {
Debug(parent_env_, DebugCategory::INSPECTOR_SERVER,
">>> %s\n", message.c_str());
if (AppendMessage(&incoming_message_queue_, action, session_id,
Utf8ToStringView(message))) {
Agent* agent = main_thread_req_->second;
@@ -395,6 +397,10 @@ void InspectorIo::MainThreadReqAsyncCb(uv_async_t* req) {

void InspectorIo::Write(TransportAction action, int session_id,
const StringView& inspector_message) {
std::string message_str =
protocol::StringUtil::StringViewToUtf8(inspector_message);
Debug(parent_env_, DebugCategory::INSPECTOR_SERVER,
"<<< %s\n", message_str.c_str());
AppendMessage(&outgoing_message_queue_, action, session_id,
StringBuffer::create(inspector_message));
int err = uv_async_send(&thread_req_);

0 comments on commit d1b750d

Please sign in to comment.
You can’t perform that action at this time.