Skip to content

Commit d332957

Browse files
abmusseaduh95
authored andcommitted
test: skip tests that cause timeouts on IBM i
I missed marking a couple of test cases flaky in my previous PR: #58583 tests missed were: - parallel.test-inspector-network-content-type - benchmark.test-benchmark-websocket After marking the above flaky I re-ran a test build and noticed the build still failed. Unfortuantely the build still fails because the build detects that node process are left behind after the tests, presumably because tests that spawn child processes are being timed out and only the parent process is killed off, leaving the child processes behind. see: #59014 (comment) We've decided to skip these tests until the underlying issue is resolved. The tests being skipped are: - parallel.test-http-proxy-fetch - parallel.test-https-proxy-fetch - benchmark.test-benchmark-websocket - parallel.test-inspector-network-fetch - parallel.test-inspector-network-content-type - es-module.test-wasm-web-api - parallel.test-fetch - parallel.test-without-async-context-frame - report.test-report-exclude-network PR-URL: #59014 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
1 parent ba380f7 commit d332957

File tree

4 files changed

+10
-7
lines changed

4 files changed

+10
-7
lines changed

test/benchmark/benchmark.status

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,3 +23,5 @@ test-benchmark-crypto: PASS, FLAKY
2323

2424
[$arch==arm]
2525

26+
[$system==ibmi]
27+
test-benchmark-websocket: SKIP

test/es-module/es-module.status

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,4 +16,4 @@ test-wasm-web-api: SKIP
1616

1717
[$system==ibmi]
1818
# https://github.com/nodejs/node/issues/58582
19-
test-wasm-web-api: PASS,FLAKY
19+
test-wasm-web-api: SKIP

test/parallel/parallel.status

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -145,11 +145,12 @@ test-tls-write-error: PASS, FLAKY
145145
# https://github.com/nodejs/node/issues/48047
146146
test-http-pipeline-flood: SKIP
147147
# https://github.com/nodejs/node/issues/58582
148-
test-http-proxy-fetch: PASS, FLAKY
149-
test-https-proxy-fetch: PASS, FLAKY
150-
test-inspector-network-fetch: PASS, FLAKY
151-
test-fetch: PASS, FLAKY
152-
test-without-async-context-frame: PASS, FLAKY
148+
test-http-proxy-fetch: SKIP
149+
test-https-proxy-fetch: SKIP
150+
test-inspector-network-fetch: SKIP
151+
test-inspector-network-content-type: SKIP
152+
test-fetch: SKIP
153+
test-without-async-context-frame: SKIP
153154
test-process-cpuUsage: PASS, FLAKY
154155

155156

test/report/report.status

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,4 @@ test-report-fatal-error: PASS, FLAKY
1212

1313
[$system==ibmi]
1414
# https://github.com/nodejs/node/issues/58582
15-
test-report-exclude-network: PASS,FLAKY
15+
test-report-exclude-network: SKIP

0 commit comments

Comments
 (0)