Permalink
Browse files

doc: explains why Reviewed-By is added in PRs

Adds verbose reasons to the documentation on why the
Reviewed-By metadata on a pull request is important.
This was loosely mentioned as an issue in the referenced
issue below, and answered by @addaleax.

Ref: #8893
PR-URL: #9044
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information...
jessqt authored and jasnell committed Oct 12, 2016
1 parent 482995e commit d529a46416b4568c32ee6fb470c4b4494c41d32e
Showing with 2 additions and 0 deletions.
  1. +2 −0 COLLABORATOR_GUIDE.md
@@ -101,6 +101,8 @@ information regarding the change process:
- A `Reviewed-By: Name <email>` line for yourself and any
other Collaborators who have reviewed the change.
- Useful for @mentions / contact list if something goes wrong in the PR.
- Protects against the assumption that GitHub will be around forever.
- A `PR-URL:` line that references the *full* GitHub URL of the original
pull request being merged so it's easy to trace a commit back to the
conversation that led up to that change.

0 comments on commit d529a46

Please sign in to comment.