Please sign in to comment.
src: do proper StringBytes error handling
- Return `MaybeLocal`s from `StringBytes::Encode` - Add an `error` out parameter to pass JS exceptions to the callers (instead of directly throwing) - Simplify some of the string generation methods in `string_bytes.cc` by unifying the `EXTERN_APEX` logic - Reduce usage of deprecated V8 APIs. - Remove error handling logic from JS, the `buffer.*Slice()` methods now throw errors themselves. - Left TODO comments for future semver-major error message improvements. This paves the way for better error messages coming out of the StringBytes methods. Ref: #3175 PR-URL: #12765 Reviewed-By: Benjamin Gruenbaum <firstname.lastname@example.org> Reviewed-By: James M Snell <email@example.com> Reviewed-By: Tobias Nießen <firstname.lastname@example.org>
- Loading branch information...
Showing with 323 additions and 186 deletions.
Oops, something went wrong.