Skip to content

Commit d774ea5

Browse files
sam-githubtargos
authored andcommitted
src: remove env-inl.h from header files
Inline headers should only be included into the .cc files that use them. PR-URL: #27755 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 02f794a commit d774ea5

20 files changed

+22
-8
lines changed

src/api/environment.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
#include "env.h"
1+
#include "env-inl.h"
22
#include "node.h"
33
#include "node_context_data.h"
44
#include "node_errors.h"

src/api/utils.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
#include "env-inl.h"
12
#include "node.h"
23
#include "node_internals.h"
34
#include "util-inl.h"

src/debug_utils.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
#include "debug_utils.h"
2+
#include "env-inl.h"
23
#include "util-inl.h"
34

45
#ifdef __POSIX__

src/debug_utils.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
#if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS
55

66
#include "async_wrap.h"
7-
#include "env-inl.h"
7+
#include "env.h"
88

99
#include <sstream>
1010
#include <string>

src/inspector_agent.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
#include "inspector_agent.h"
22

3+
#include "env-inl.h"
34
#include "inspector/main_thread_interface.h"
45
#include "inspector/node_string.h"
56
#include "inspector/runtime_agent.h"

src/js_native_api_v8.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
#include <cmath>
33
#include <algorithm>
44
#define NAPI_EXPERIMENTAL
5+
#include "env-inl.h"
56
#include "js_native_api_v8.h"
67
#include "js_native_api.h"
78
#include "util-inl.h"

src/node_api.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#include <node_buffer.h>
2-
#include "env.h"
2+
#include "env-inl.h"
33
#define NAPI_EXPERIMENTAL
44
#include "js_native_api_v8.h"
55
#include "node_api.h"

src/node_constants.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
2020
// USE OR OTHER DEALINGS IN THE SOFTWARE.
2121

22+
#include "env-inl.h"
2223
#include "node_constants.h"
2324
#include "node_internals.h"
2425
#include "util-inl.h"

src/node_credentials.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
#include "env-inl.h"
12
#include "node_internals.h"
23
#include "util-inl.h"
34

src/node_internals.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424

2525
#if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS
2626

27-
#include "env-inl.h"
27+
#include "env.h"
2828
#include "node.h"
2929
#include "node_binding.h"
3030
#include "node_mutex.h"

0 commit comments

Comments
 (0)