Skip to content

Commit de643bc

Browse files
addaleaxtargos
authored andcommitted
src: use unique_ptr for CachedData in ContextifyScript::New
This closes a memory leak. PR-URL: #33113 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
1 parent 3866dc1 commit de643bc

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/node_contextify.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -764,8 +764,8 @@ void ContextifyScript::New(const FunctionCallbackInfo<Value>& args) {
764764
env->cached_data_rejected_string(),
765765
Boolean::New(isolate, source.GetCachedData()->rejected)).Check();
766766
} else if (produce_cached_data) {
767-
const ScriptCompiler::CachedData* cached_data =
768-
ScriptCompiler::CreateCodeCache(v8_script.ToLocalChecked());
767+
std::unique_ptr<ScriptCompiler::CachedData> cached_data {
768+
ScriptCompiler::CreateCodeCache(v8_script.ToLocalChecked()) };
769769
bool cached_data_produced = cached_data != nullptr;
770770
if (cached_data_produced) {
771771
MaybeLocal<Object> buf = Buffer::Copy(

0 commit comments

Comments
 (0)