Skip to content

Commit dfc66a6

Browse files
addaleaxBethGriggs
authored andcommitted
deps: V8: cherry-pick d1253ae95b09
Original commit message: [unwinder] Advance deprecation of the old unwinder API Chrome uses the new version now. Bug: v8:8116 Change-Id: I59af8d2c6a897a852acd6de3a7938a4b8d3943e4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2110015 Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#66796} Refs: v8/v8@d1253ae PR-URL: #32885 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
1 parent c3ecbc7 commit dfc66a6

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

common.gypi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535

3636
# Reset this number to 0 on major V8 upgrades.
3737
# Increment by one for each non-official patch applied to deps/v8.
38-
'v8_embedder_string': '-node.18',
38+
'v8_embedder_string': '-node.19',
3939

4040
##### V8 defaults for Node.js #####
4141

deps/v8/include/v8.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9180,7 +9180,7 @@ class V8_EXPORT Isolate {
91809180
* Returns the UnwindState necessary for use with the Unwinder API.
91819181
*/
91829182
// TODO(petermarshall): Remove this API.
9183-
V8_DEPRECATE_SOON("Use entry_stubs + code_pages version.")
9183+
V8_DEPRECATED("Use entry_stubs + code_pages version.")
91849184
UnwindState GetUnwindState();
91859185

91869186
/**
@@ -10534,7 +10534,7 @@ class V8_EXPORT Unwinder {
1053410534
* \return True on success.
1053510535
*/
1053610536
// TODO(petermarshall): Remove this API
10537-
V8_DEPRECATE_SOON("Use entry_stubs + code_pages version.")
10537+
V8_DEPRECATED("Use entry_stubs + code_pages version.")
1053810538
static bool TryUnwindV8Frames(const UnwindState& unwind_state,
1053910539
RegisterState* register_state,
1054010540
const void* stack_base);
@@ -10562,7 +10562,7 @@ class V8_EXPORT Unwinder {
1056210562
* (but not necessarily) be successful.
1056310563
*/
1056410564
// TODO(petermarshall): Remove this API
10565-
V8_DEPRECATE_SOON("Use code_pages version.")
10565+
V8_DEPRECATED("Use code_pages version.")
1056610566
static bool PCIsInV8(const UnwindState& unwind_state, void* pc);
1056710567

1056810568
/**

0 commit comments

Comments
 (0)