Skip to content

Commit e32b10f

Browse files
addaleaxtargos
authored andcommitted
build: set disable_glibcxx_debug flag
This breaks a few tests when Node is built in debug mode, because V8 is built with `-D_GLIBCXX_DEBUG=1` and Node is built without, which makes e.g. `std::vector` ABI-incompatible between the two. PR-URL: #16159 Reviewed-By: James Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
1 parent ea0fec2 commit e32b10f

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

common.gypi

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,10 @@
3131
# Don't bake anything extra into the snapshot.
3232
'v8_use_external_startup_data%': 0,
3333

34+
# Some STL containers (e.g. std::vector) do not preserve ABI compatibility
35+
# between debug and non-debug mode.
36+
'disable_glibcxx_debug': 1,
37+
3438
# Don't use ICU data file (icudtl.dat) from V8, we use our own.
3539
'icu_use_data_file_flag%': 0,
3640

0 commit comments

Comments
 (0)