Skip to content

Commit e7084df

Browse files
himself65targos
authored andcommitted
sqlite: add sqlite-type symbol for DatabaseSync
PR-URL: #59405 Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
1 parent e964c43 commit e7084df

File tree

2 files changed

+16
-0
lines changed

2 files changed

+16
-0
lines changed

src/node_sqlite.cc

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2741,6 +2741,13 @@ static void Initialize(Local<Object> target,
27412741
db_tmpl,
27422742
FIXED_ONE_BYTE_STRING(isolate, "isTransaction"),
27432743
DatabaseSync::IsTransactionGetter);
2744+
Local<String> sqlite_type_key = FIXED_ONE_BYTE_STRING(isolate, "sqlite-type");
2745+
Local<v8::Symbol> sqlite_type_symbol =
2746+
v8::Symbol::For(isolate, sqlite_type_key);
2747+
Local<String> database_sync_string =
2748+
FIXED_ONE_BYTE_STRING(isolate, "node:sqlite");
2749+
db_tmpl->InstanceTemplate()->Set(sqlite_type_symbol, database_sync_string);
2750+
27442751
SetConstructorFunction(context, target, "DatabaseSync", db_tmpl);
27452752
SetConstructorFunction(context,
27462753
target,

test/parallel/test-sqlite-database-sync.js

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -281,6 +281,15 @@ suite('DatabaseSync() constructor', () => {
281281
{ changes: 1, lastInsertRowid: 1 },
282282
);
283283
});
284+
285+
test('has sqlite-type symbol property', (t) => {
286+
const dbPath = nextDb();
287+
const db = new DatabaseSync(dbPath);
288+
t.after(() => { db.close(); });
289+
290+
const sqliteTypeSymbol = Symbol.for('sqlite-type');
291+
t.assert.strictEqual(db[sqliteTypeSymbol], 'node:sqlite');
292+
});
284293
});
285294

286295
suite('DatabaseSync.prototype.open()', () => {

0 commit comments

Comments
 (0)