Skip to content

Commit eac377b

Browse files
committed
deps: V8: backport aaacffa1e003
Original commit message: PPC: skip all Simd tests on PPC As of https://crrev.com/c/2629465, Simd tests cannot pass on architectures without Simd support. Tests will need to be re-enabled once Simd support is fully implemented on PPC. Change-Id: I963639f1afa0c0ca7be3ca4b2fc06e874235b903 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2693056 Reviewed-by: Zhi An Ng <zhin@chromium.org> Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#72788} Refs: v8/v8@aaacffa PR-URL: #38273 Backport-PR-URL: #38991 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Mary Marchini <oss@mmarchini.me>
1 parent 1a7c8a1 commit eac377b

File tree

3 files changed

+10
-1
lines changed

3 files changed

+10
-1
lines changed

common.gypi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.5',
39+
'v8_embedder_string': '-node.6',
4040

4141
##### V8 defaults for Node.js #####
4242

deps/v8/test/message/message.status

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,11 @@
7070
}],
7171

7272
################################################################################
73+
['arch == ppc64', {
74+
# Tests that require Simd enabled.
75+
'wasm-trace-memory': [SKIP],
76+
}],
77+
7378
['arch == mips64el or arch == mipsel', {
7479
# Tests that require Simd enabled.
7580
'wasm-trace-memory': [SKIP],

deps/v8/tools/testrunner/base_runner.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -654,6 +654,10 @@ def _get_statusfile_variables(self, options):
654654
self.build_config.arch == 'mipsel':
655655
no_simd_sse = not simd_mips
656656

657+
# Set no_simd_sse on architectures without Simd enabled.
658+
if self.build_config.arch == 'ppc64':
659+
no_simd_sse = True
660+
657661
return {
658662
"arch": self.build_config.arch,
659663
"asan": self.build_config.asan,

0 commit comments

Comments
 (0)