Skip to content

Commit eba2c62

Browse files
committed
benchmark: remove forced optimization from path
This removes all instances of %OptimizeFunctionOnNextCall from path benchmarks PR-URL: #9615 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
1 parent 7587a11 commit eba2c62

21 files changed

+17
-150
lines changed

benchmark/path/basename-posix.js

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
'use strict';
22
var common = require('../common.js');
33
var path = require('path');
4-
var v8 = require('v8');
54

65
var bench = common.createBenchmark(main, {
76
pathext: [
@@ -30,12 +29,6 @@ function main(conf) {
3029
input = input.slice(0, extIdx);
3130
}
3231

33-
// Force optimization before starting the benchmark
34-
p.basename(input, ext);
35-
v8.setFlagsFromString('--allow_natives_syntax');
36-
eval('%OptimizeFunctionOnNextCall(p.basename)');
37-
p.basename(input, ext);
38-
3932
bench.start();
4033
for (var i = 0; i < n; i++) {
4134
p.basename(input, ext);

benchmark/path/basename-win32.js

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
'use strict';
22
var common = require('../common.js');
33
var path = require('path');
4-
var v8 = require('v8');
54

65
var bench = common.createBenchmark(main, {
76
pathext: [
@@ -30,12 +29,6 @@ function main(conf) {
3029
input = input.slice(0, extIdx);
3130
}
3231

33-
// Force optimization before starting the benchmark
34-
p.basename(input, ext);
35-
v8.setFlagsFromString('--allow_natives_syntax');
36-
eval('%OptimizeFunctionOnNextCall(p.basename)');
37-
p.basename(input, ext);
38-
3932
bench.start();
4033
for (var i = 0; i < n; i++) {
4134
p.basename(input, ext);

benchmark/path/dirname-posix.js

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
'use strict';
22
var common = require('../common.js');
33
var path = require('path');
4-
var v8 = require('v8');
54

65
var bench = common.createBenchmark(main, {
76
path: [
@@ -21,12 +20,6 @@ function main(conf) {
2120
var p = path.posix;
2221
var input = '' + conf.path;
2322

24-
// Force optimization before starting the benchmark
25-
p.dirname(input);
26-
v8.setFlagsFromString('--allow_natives_syntax');
27-
eval('%OptimizeFunctionOnNextCall(p.dirname)');
28-
p.dirname(input);
29-
3023
bench.start();
3124
for (var i = 0; i < n; i++) {
3225
p.dirname(input);

benchmark/path/dirname-win32.js

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
'use strict';
22
var common = require('../common.js');
33
var path = require('path');
4-
var v8 = require('v8');
54

65
var bench = common.createBenchmark(main, {
76
path: [
@@ -21,12 +20,6 @@ function main(conf) {
2120
var p = path.win32;
2221
var input = '' + conf.path;
2322

24-
// Force optimization before starting the benchmark
25-
p.dirname(input);
26-
v8.setFlagsFromString('--allow_natives_syntax');
27-
eval('%OptimizeFunctionOnNextCall(p.dirname)');
28-
p.dirname(input);
29-
3023
bench.start();
3124
for (var i = 0; i < n; i++) {
3225
p.dirname(input);

benchmark/path/extname-posix.js

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
'use strict';
22
var common = require('../common.js');
33
var path = require('path');
4-
var v8 = require('v8');
54

65
var bench = common.createBenchmark(main, {
76
path: [
@@ -24,12 +23,6 @@ function main(conf) {
2423
var p = path.posix;
2524
var input = '' + conf.path;
2625

27-
// Force optimization before starting the benchmark
28-
p.extname(input);
29-
v8.setFlagsFromString('--allow_natives_syntax');
30-
eval('%OptimizeFunctionOnNextCall(p.extname)');
31-
p.extname(input);
32-
3326
bench.start();
3427
for (var i = 0; i < n; i++) {
3528
p.extname(input);

benchmark/path/extname-win32.js

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
'use strict';
22
var common = require('../common.js');
33
var path = require('path');
4-
var v8 = require('v8');
54

65
var bench = common.createBenchmark(main, {
76
path: [
@@ -24,12 +23,6 @@ function main(conf) {
2423
var p = path.win32;
2524
var input = '' + conf.path;
2625

27-
// Force optimization before starting the benchmark
28-
p.extname(input);
29-
v8.setFlagsFromString('--allow_natives_syntax');
30-
eval('%OptimizeFunctionOnNextCall(p.extname)');
31-
p.extname(input);
32-
3326
bench.start();
3427
for (var i = 0; i < n; i++) {
3528
p.extname(input);

benchmark/path/format-posix.js

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
'use strict';
22
var common = require('../common.js');
33
var path = require('path');
4-
var v8 = require('v8');
54

65
var bench = common.createBenchmark(main, {
76
props: [
@@ -22,12 +21,6 @@ function main(conf) {
2221
name: props[4] || '',
2322
};
2423

25-
// Force optimization before starting the benchmark
26-
p.format(obj);
27-
v8.setFlagsFromString('--allow_natives_syntax');
28-
eval('%OptimizeFunctionOnNextCall(p.format)');
29-
p.format(obj);
30-
3124
bench.start();
3225
for (var i = 0; i < n; i++) {
3326
p.format(obj);

benchmark/path/format-win32.js

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
'use strict';
22
var common = require('../common.js');
33
var path = require('path');
4-
var v8 = require('v8');
54

65
var bench = common.createBenchmark(main, {
76
props: [
@@ -22,12 +21,6 @@ function main(conf) {
2221
name: props[4] || '',
2322
};
2423

25-
// Force optimization before starting the benchmark
26-
p.format(obj);
27-
v8.setFlagsFromString('--allow_natives_syntax');
28-
eval('%OptimizeFunctionOnNextCall(p.format)');
29-
p.format(obj);
30-
3124
bench.start();
3225
for (var i = 0; i < n; i++) {
3326
p.format(obj);

benchmark/path/isAbsolute-posix.js

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
'use strict';
22
var common = require('../common.js');
33
var path = require('path');
4-
var v8 = require('v8');
54

65
var bench = common.createBenchmark(main, {
76
path: [
@@ -19,12 +18,6 @@ function main(conf) {
1918
var p = path.posix;
2019
var input = '' + conf.path;
2120

22-
// Force optimization before starting the benchmark
23-
p.isAbsolute(input);
24-
v8.setFlagsFromString('--allow_natives_syntax');
25-
eval('%OptimizeFunctionOnNextCall(p.isAbsolute)');
26-
p.isAbsolute(input);
27-
2821
bench.start();
2922
for (var i = 0; i < n; i++) {
3023
p.isAbsolute(input);

benchmark/path/isAbsolute-win32.js

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
'use strict';
22
var common = require('../common.js');
33
var path = require('path');
4-
var v8 = require('v8');
54

65
var bench = common.createBenchmark(main, {
76
path: [
@@ -20,12 +19,6 @@ function main(conf) {
2019
var p = path.win32;
2120
var input = '' + conf.path;
2221

23-
// Force optimization before starting the benchmark
24-
p.isAbsolute(input);
25-
v8.setFlagsFromString('--allow_natives_syntax');
26-
eval('%OptimizeFunctionOnNextCall(p.isAbsolute)');
27-
p.isAbsolute(input);
28-
2922
bench.start();
3023
for (var i = 0; i < n; i++) {
3124
p.isAbsolute(input);

0 commit comments

Comments
 (0)