Permalink
Browse files

tools: enable no-useless-constructor lint rule

This commit enables ESLint's no-useless-constructor rule. Note
that the documentation examples that only include constructor
calls were left in tact.

PR-URL: #25055
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information...
cjihrig authored and MylesBorins committed Dec 15, 2018
1 parent 09a99c6 commit ed3303ba9939e9bf5d1198d70393b20be48c2eff
Showing with 6 additions and 15 deletions.
  1. +1 −0 .eslintrc.js
  2. +5 −5 doc/api/stream.md
  3. +0 −2 lib/perf_hooks.js
  4. +0 −4 lib/v8.js
  5. +0 −4 test/parallel/test-stream-writable-null.js
@@ -235,6 +235,7 @@ module.exports = {
}],
'no-useless-call': 'error',
'no-useless-concat': 'error',
'no-useless-constructor': 'error',
'no-useless-escape': 'error',
'no-useless-return': 'error',
'no-void': 'error',
@@ -1450,6 +1450,7 @@ of the four basic stream classes (`stream.Writable`, `stream.Readable`,
`stream.Duplex`, or `stream.Transform`), making sure they call the appropriate
parent class constructor:

<!-- eslint-disable no-useless-constructor -->
```js
const { Writable } = require('stream');
@@ -1547,6 +1548,7 @@ changes:
* `autoDestroy` {boolean} Whether this stream should automatically call
`.destroy()` on itself after ending. **Default:** `false`.

<!-- eslint-disable no-useless-constructor -->
```js
const { Writable } = require('stream');
@@ -1718,11 +1720,6 @@ required elements of a custom [`Writable`][] stream instance:
const { Writable } = require('stream');
class MyWritable extends Writable {
constructor(options) {
super(options);
// ...
}
_write(chunk, encoding, callback) {
if (chunk.toString().indexOf('a') >= 0) {
callback(new Error('chunk is invalid'));
@@ -1806,6 +1803,7 @@ changes:
* `autoDestroy` {boolean} Whether this stream should automatically call
`.destroy()` on itself after ending. **Default:** `false`.

<!-- eslint-disable no-useless-constructor -->
```js
const { Readable } = require('stream');
@@ -2064,6 +2062,7 @@ changes:
* `writableHighWaterMark` {number} Sets `highWaterMark` for the writable side
of the stream. Has no effect if `highWaterMark` is provided.

<!-- eslint-disable no-useless-constructor -->
```js
const { Duplex } = require('stream');
@@ -2218,6 +2217,7 @@ output on the `Readable` side is not consumed.
* `flush` {Function} Implementation for the [`stream._flush()`][stream-_flush]
method.

<!-- eslint-disable no-useless-constructor -->
```js
const { Transform } = require('stream');
@@ -143,8 +143,6 @@ function getMilestoneTimestamp(milestoneIdx) {
}

class PerformanceNodeTiming {
constructor() {}

get name() {
return 'node';
}
@@ -172,10 +172,6 @@ class DefaultSerializer extends Serializer {
}

class DefaultDeserializer extends Deserializer {
constructor(buffer) {
super(buffer);
}

_readHostObject() {
const typeIndex = this.readUint32();
const ctor = arrayBufferViewTypes[typeIndex];
@@ -5,10 +5,6 @@ const assert = require('assert');
const stream = require('stream');

class MyWritable extends stream.Writable {
constructor(opt) {
super(opt);
}

_write(chunk, encoding, callback) {
assert.notStrictEqual(chunk, null);
callback();

0 comments on commit ed3303b

Please sign in to comment.