dns: set timeout to 1000ms when timeout < 0

theanarkh · targos · commit f40ac32f3e8b · 2025-07-03T10:50:11.000+02:00
PR-URL: #58441 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/src/cares_wrap.cc b/src/cares_wrap.cc
@@ -902,8 +902,7 @@ void ChannelWrap::StartTimer() {
     return;
   }
   int timeout = timeout_;
-  if (timeout == 0) timeout = 1;
-  if (timeout < 0 || timeout > 1000) timeout = 1000;
+  if (timeout <= 0 || timeout > 1000) timeout = 1000;
   uv_timer_start(timer_handle_, AresTimeout, timeout, timeout);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -902,8 +902,7 @@ void ChannelWrap::StartTimer() {`
`902`	`902`	`return;`
`903`	`903`	`}`
`904`	`904`	`int timeout = timeout_;`
`905`		`- if (timeout == 0) timeout = 1;`
`906`		`- if (timeout < 0 \|\| timeout > 1000) timeout = 1000;`
	`905`	`+ if (timeout <= 0 \|\| timeout > 1000) timeout = 1000;`
`907`	`906`	`uv_timer_start(timer_handle_, AresTimeout, timeout, timeout);`
`908`	`907`	`}`
`909`	`908`