Skip to content

Commit f90eba1

Browse files
joaocgreismmarchini
authored andcommitted
deps: make v8.h compatible with VS2015
There is a bug in the most recent version of VS2015 that affects v8.h and therefore prevents compilation of addons. Refs: https://stackoverflow.com/q/38378693 PR-URL: #32116 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1 parent 56b6a4f commit f90eba1

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

common.gypi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535

3636
# Reset this number to 0 on major V8 upgrades.
3737
# Increment by one for each non-official patch applied to deps/v8.
38-
'v8_embedder_string': '-node.5',
38+
'v8_embedder_string': '-node.6',
3939

4040
##### V8 defaults for Node.js #####
4141

deps/v8/include/v8.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1773,9 +1773,11 @@ class V8_EXPORT ScriptCompiler {
17731773
public:
17741774
enum Encoding { ONE_BYTE, TWO_BYTE, UTF8 };
17751775

1776+
#if defined(_MSC_VER) && _MSC_VER >= 1910 /* Disable on VS2015 */
17761777
V8_DEPRECATE_SOON(
17771778
"This class takes ownership of source_stream, so use the constructor "
17781779
"taking a unique_ptr to make these semantics clearer")
1780+
#endif
17791781
StreamedSource(ExternalSourceStream* source_stream, Encoding encoding);
17801782
StreamedSource(std::unique_ptr<ExternalSourceStream> source_stream,
17811783
Encoding encoding);

0 commit comments

Comments
 (0)