Skip to content
Permalink
Browse files

http: destructure primordials in lib/_http_server.js

PR-URL: #30315
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
  • Loading branch information
artmaks authored and MylesBorins committed Nov 6, 2019
1 parent a621ab8 commit fdfcf68360f1f2fce4a483ee3adaf84c3ddda065
Showing with 12 additions and 7 deletions.
  1. +12 −7 lib/_http_server.js
@@ -21,7 +21,12 @@

'use strict';

const { Object } = primordials;
const {
Object: {
setPrototypeOf: ObjectSetPrototypeOf,
keys: ObjectKeys,
}
} = primordials;

const net = require('net');
const assert = require('internal/assert');
@@ -165,8 +170,8 @@ function ServerResponse(req) {
};
}
}
Object.setPrototypeOf(ServerResponse.prototype, OutgoingMessage.prototype);
Object.setPrototypeOf(ServerResponse, OutgoingMessage);
ObjectSetPrototypeOf(ServerResponse.prototype, OutgoingMessage.prototype);
ObjectSetPrototypeOf(ServerResponse, OutgoingMessage);

ServerResponse.prototype._finish = function _finish() {
DTRACE_HTTP_SERVER_RESPONSE(this.connection);
@@ -258,8 +263,8 @@ function writeHead(statusCode, reason, obj) {
// Slow-case: when progressive API and header fields are passed.
let k;
if (obj) {
const keys = Object.keys(obj);
for (let i = 0; i < keys.length; i++) {
const keys = ObjectKeys(obj);
for (var i = 0; i < keys.length; i++) {
k = keys[i];
if (k) this.setHeader(k, obj[k]);
}
@@ -341,8 +346,8 @@ function Server(options, requestListener) {
this.maxHeadersCount = null;
this.headersTimeout = 40 * 1000; // 40 seconds
}
Object.setPrototypeOf(Server.prototype, net.Server.prototype);
Object.setPrototypeOf(Server, net.Server);
ObjectSetPrototypeOf(Server.prototype, net.Server.prototype);
ObjectSetPrototypeOf(Server, net.Server);


Server.prototype.setTimeout = function setTimeout(msecs, callback) {

0 comments on commit fdfcf68

Please sign in to comment.
You can’t perform that action at this time.