-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor test/inspector #13622
Comments
@refack A rough estimate on when the merging would be done ? |
Hopefully < 1 month 🤷♂️ |
Permission to call dibs now for this ? :P |
I think in general it's a "better to ask forgiveness than permission" situation. |
@adityaanandmc how are you with |
@refack fairly alright! Plus if all else fails, there is Do you have something in mind I can help out with ? |
Should be able to be closed since #16197 was merged ( |
I think the metadata generator needs the |
Especially now that it's not experimental, it seems that it would make sense to:
test/inspector
intotest/sequential
and/ortest/parallel
as appropriatetest/inspector/global-functions.js
intotest/fixtures
test/inspector-helper.js
totest/common/inspector-helper.js
Basically, get rid of the
inspector
-specific directory.Or is there real benefit to having it all in its own directory?
@nodejs/testing
The text was updated successfully, but these errors were encountered: