Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N-API: Enforce handle scope semantics more strictly #16175

Closed
addaleax opened this issue Oct 13, 2017 · 0 comments
Closed

N-API: Enforce handle scope semantics more strictly #16175

addaleax opened this issue Oct 13, 2017 · 0 comments
Labels
node-api Issues and PRs related to the Node-API.

Comments

@addaleax
Copy link
Member

The addons-napi/test_handle_scope is currently failing in debug mode because in at least one case a handle scope is opened but never closed (because it bails out on an error before it can finish). Obviously, the test case can be fixed, but we might want to give this a bit more thought:

  • Do we want to only have this check active in debug mode? I’d say no.
  • Should we error out (i.e. crash) if users don’t close all handle scopes they have opened? I’d say yes.

@nodejs/n-api
@addaleax addaleax added the node-api Issues and PRs related to the Node-API. label Oct 13, 2017
@mhdawson mhdawson mentioned this issue Oct 13, 2017
Open
7 tasks
addaleax added a commit to addaleax/node that referenced this issue Oct 14, 2017
@addaleax
n-api: check against invalid handle scope usage
e6331b3 
Fixes: nodejs#16175
@addaleax addaleax mentioned this issue Oct 14, 2017
Closed
3 tasks
addaleax added a commit to ayojs/ayo that referenced this issue Oct 18, 2017
@addaleax
n-api: check against invalid handle scope usage
fd8ca8f 
Fixes: nodejs/node#16175
PR-URL: nodejs/node#16201
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit that referenced this issue Oct 18, 2017
@addaleax @targos
n-api: check against invalid handle scope usage
0a52479 
Fixes: #16175
PR-URL: #16201
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this issue Apr 16, 2018
@addaleax
n-api: check against invalid handle scope usage
96d1334 
Fixes: nodejs#16175
PR-URL: nodejs#16201
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this issue Apr 16, 2018
@addaleax @MylesBorins
n-api: check against invalid handle scope usage
55aab6b 
Fixes: #16175
Backport-PR-URL: #19447
PR-URL: #16201
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
node-api Issues and PRs related to the Node-API.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@addaleax