Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support UV_FS_COPYFILE_FICLONE #19152

Closed
Tracked by #19970
langpavel opened this issue Mar 5, 2018 · 2 comments
Closed
Tracked by #19970

Support UV_FS_COPYFILE_FICLONE #19152

langpavel opened this issue Mar 5, 2018 · 2 comments

Comments

@langpavel
Copy link
Contributor

UV_FS_COPYFILE_FICLONE was just merged to libuv: unix: add UV_FS_COPYFILE_FICLONE support

When will be this merged into node? Will this be backported to node 8?
@cjihrig
Copy link
Contributor

cjihrig commented Mar 5, 2018

I'll be adding support for it when the next libuv update is merged. My guess is that it will be backported to Node 8, as most of the work happens in libuv.

@langpavel langpavel mentioned this issue Mar 5, 2018
Closed
2 tasks
@langpavel
Copy link
Contributor Author

langpavel commented Mar 5, 2018 •
edited
Loading

Relevant paragraph from libuv docs:

.. c:function:: int uv_fs_copyfile(uv_loop_t* loop, uv_fs_t* req, const char* path, const char* new_path, int flags, uv_fs_cb cb)
Copies a file from path to new_path. Supported flags are described below.
—————————————————————————————
- UV_FS_COPYFILE_FICLONE: If present, uv_fs_copyfile() will attempt to
create a copy-on-write reflink. If the underlying platform does not
support copy-on-write, then a fallback copy mechanism is used.
—————————————————————————————
.. versionchanged:: 1.20.0 UV_FS_COPYFILE_FICLONE is supported.

This was referenced Mar 5, 2018
Open
Closed
@cjihrig cjihrig mentioned this issue Apr 2, 2018
Closed
4 tasks
cjihrig added a commit to cjihrig/node that referenced this issue Apr 6, 2018
@cjihrig
fs: expose copy-on-write flags for fs.copyFile()
31e63ca 
This commit exposes the UV_FS_COPYFILE_FICLONE and
UV_FS_COPYFILE_FICLONE_FORCE flags added in libuv 1.20.0.

Fixes: nodejs#19152
PR-URL: nodejs#19759
Fixes: nodejs#19152
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@cjihrig cjihrig closed this as completed in a16d88d Apr 6, 2018
targos pushed a commit that referenced this issue Apr 6, 2018
@cjihrig @targos
fs: expose copy-on-write flags for fs.copyFile()
5ecd82d 
This commit exposes the UV_FS_COPYFILE_FICLONE and
UV_FS_COPYFILE_FICLONE_FORCE flags added in libuv 1.20.0.

Fixes: #19152
PR-URL: #19759
Fixes: #19152
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR pushed a commit to BridgeAR/node that referenced this issue May 1, 2018
@cjihrig @BridgeAR
fs: expose copy-on-write flags for fs.copyFile()
3bdc9ef 
This commit exposes the UV_FS_COPYFILE_FICLONE and
UV_FS_COPYFILE_FICLONE_FORCE flags added in libuv 1.20.0.

Fixes: nodejs#19152
PR-URL: nodejs#19759
Fixes: nodejs#19152
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@langpavel @cjihrig