Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test-bootstrap-modules.js fails on master #26528

Closed
tniessen opened this Issue Mar 8, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@tniessen
Copy link
Member

tniessen commented Mar 8, 2019

  • Version: master
  • Platform: Travis CI, Jenkins CI
  • Subsystem: test

test/parallel/test-bootstrap-modules.js fails on Travis and Jenkins:

=== release test-bootstrap-modules ===
Path: parallel/test-bootstrap-modules
assert.js:340
    throw err;
    ^
AssertionError [ERR_ASSERTION]: Total length: 65
Internal Binding module_wrap
Internal Binding native_module
Internal Binding config
NativeModule internal/util
NativeModule internal/errors
Internal Binding buffer
Internal Binding constants
Internal Binding util
NativeModule internal/util/types
Internal Binding types
NativeModule events
NativeModule buffer
NativeModule internal/util/inspect
NativeModule internal/assert
NativeModule internal/validators
NativeModule internal/buffer
Internal Binding icu
NativeModule internal/process/per_thread
NativeModule util
NativeModule internal/util/debuglog
NativeModule internal/encoding
NativeModule internal/process/main_thread_only
Internal Binding process_methods
NativeModule internal/process/warning
NativeModule internal/process/next_tick
Internal Binding task_queue
NativeModule internal/process/promises
NativeModule internal/async_hooks
NativeModule internal/options
Internal Binding options
Internal Binding async_wrap
NativeModule internal/fixed_queue
Internal Binding credentials
NativeModule internal/process/stdio
NativeModule internal/inspector_async_hook
Internal Binding inspector
NativeModule internal/console/global
NativeModule internal/console/constructor
Internal Binding trace_events
NativeModule internal/util/inspector
NativeModule internal/url
NativeModule internal/querystring
NativeModule internal/constants
NativeModule path
Internal Binding url
NativeModule timers
Internal Binding timers
NativeModule internal/linkedlist
NativeModule internal/priority_queue
NativeModule internal/timers
NativeModule internal/queue_microtask
NativeModule async_hooks
NativeModule internal/domexception
Internal Binding messaging
NativeModule internal/process/execution
NativeModule internal/bootstrap/pre_execution
NativeModule internal/modules/cjs/loader
NativeModule vm
Internal Binding contextify
NativeModule fs
Internal Binding fs
NativeModule internal/fs/utils
NativeModule internal/modules/cjs/helpers
NativeModule url
NativeModule internal/idna
    at Object.<anonymous> (/home/travis/build/nodejs/node/test/parallel/test-bootstrap-modules.js:15:1)
    at Module._compile (internal/modules/cjs/loader.js:813:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:824:10)
    at Module.load (internal/modules/cjs/loader.js:680:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:612:12)
    at Function.Module._load (internal/modules/cjs/loader.js:604:3)
    at Function.Module.runMain (internal/modules/cjs/loader.js:876:12)
    at internal/main/run_main_module.js:21:11
Command: out/Release/node --expose-internals /home/travis/build/nodejs/node/test/parallel/test-bootstrap-modules.js

Travis failure: https://travis-ci.com/nodejs/node/jobs/183422190
Jenkins failure: https://ci.nodejs.org/job/node-test-pull-request/21335/

@richardlau

This comment has been minimized.

Copy link
Member

richardlau commented Mar 8, 2019

Being fixed by #26520.

@richardlau richardlau pinned this issue Mar 8, 2019

@tniessen tniessen referenced this issue Mar 8, 2019

Merged

test: bump test-bootstrap-modules.js limit #26520

3 of 3 tasks complete

refack added a commit to joyeecheung/node that referenced this issue Mar 8, 2019

test: bump test-bootstrap-modules.js limit
PR-URL: nodejs#26520
Fixes: nodejs#26528
Refs: nodejs#25594
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

@refack refack closed this in #26520 Mar 8, 2019

@refack refack unpinned this issue Mar 8, 2019

@refack refack pinned this issue Mar 8, 2019

@Trott Trott unpinned this issue Mar 9, 2019

BridgeAR added a commit to BridgeAR/node that referenced this issue Mar 12, 2019

test: bump test-bootstrap-modules.js limit
PR-URL: nodejs#26520
Fixes: nodejs#26528
Refs: nodejs#25594
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

BridgeAR added a commit to BridgeAR/node that referenced this issue Mar 13, 2019

test: bump test-bootstrap-modules.js limit
PR-URL: nodejs#26520
Fixes: nodejs#26528
Refs: nodejs#25594
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

BridgeAR added a commit that referenced this issue Mar 14, 2019

test: bump test-bootstrap-modules.js limit
PR-URL: #26520
Fixes: #26528
Refs: #25594
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.